Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug patronum #126

Merged
merged 1 commit into from Sep 26, 2022
Merged

Fix debug patronum #126

merged 1 commit into from Sep 26, 2022

Conversation

raidenmiro
Copy link
Contributor

  1. Fix false positives from the rule and add test case.

Example:

const $store = createStore(false).on(open, () => true)
  1. Add a more correct deletion of the line with debug and add test case (properly saving the formatting)
// from
import { condition, debug, delay } from 'patronum'

const $store = createStore(false)

const createTest = () => {
  const state = {
    equal(a, b) {
      return a === b
    }
  }
  debug($store)
  return state
}
// into
import { condition, delay } from 'patronum'

const $store = createStore(false)

const createTest = () => {
  const state = {
    equal(a, b) {
      return a === b
    }
  }
  return state
}

Fix false positives from the rule

Add test case when there are no import

Fix delete without formatting loss when using semicolon
@igorkamyshev
Copy link
Member

lgtm, thanks, will be released in an hour ✔️

@igorkamyshev igorkamyshev merged commit e5baff2 into effector:master Sep 26, 2022
@igorkamyshev
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants