Skip to content

Add rule no-unnecessary-combination#43

Merged
igorkamyshev merged 5 commits intomasterfrom
no-unnecessary-combination
Oct 7, 2021
Merged

Add rule no-unnecessary-combination#43
igorkamyshev merged 5 commits intomasterfrom
no-unnecessary-combination

Conversation

@igorkamyshev
Copy link
Member

fixes #8

@github-actions
Copy link

Total Coverage: 95.52%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.48% 35, 36, 72, 73, 96, 97
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 94.83% 100, 123, 124, 72, 73, 99
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 95.83% 32, 33
rules/no-unnecessary-combination
   no-unnecessary-combination.js 75% 100% 93.10% 53, 57, 58, 70, 71
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.29% 33, 34, 49, 50, 67, 68

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Total Coverage: 96.04%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 37, 38, 74, 75, 98, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 119, 120, 144, 145, 91, 92
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 75% 100% 93.33% 55, 59, 60, 72, 73
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@igorkamyshev igorkamyshev marked this pull request as ready for review October 7, 2021 14:36
@igorkamyshev igorkamyshev merged commit 0795b3b into master Oct 7, 2021
@igorkamyshev igorkamyshev deleted the no-unnecessary-combination branch October 7, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rule: no-unnecessary-combinations

1 participant