Rule no watch

[binjospookie]

close #48

[igorkamyshev]

Thanks for your contribution, it's a great help 💙

I've left some questions about the code and the documentation.

In general, I like it. I think we can release this rule in 0.4.0 on the next week.

[igorkamyshev]

Let's add some smoke cases to correct test. E.g. sample({ ... }), `forward({...}), etc.

[binjospookie]

Made all necessary changes.

[igorkamyshev]

Great job!

I think, we are ready to merge it. I've left some comments about test-cases. Once you fix it, I'll merge PR.

[igorkamyshev]

This pattern leads to hard debugging. Could you split incorrect test-cases and put it by files with only one error?

[binjospookie]

Do you mean that for every incorrect case there should be a separate file?
1 error per file

For example: effects has 5 cases => 5 files

Am I right?

[igorkamyshev]

Hm, in this case up to you. I think, it's easier to debug in case of broken tests, but I can be wrong here.

[binjospookie]

You right. I choose a solution in the middle. No more than 2 errors per case.

[binjospookie]

Nice. I'll try to fix it asap 🙂

[igorkamyshev]

Let me know, when you'll be ready to merge. For me, this PR looks good.

[binjospookie]

I'm ready to merge🙃

[igorkamyshev]

Thanks! Will be released in a week with 0.4.0.

[binjospookie]

Thank u too!