Skip to content

Fix no-useless-methods false-positive cases #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
igorkamyshev merged 3 commits into from
Dec 9, 2021
Merged

Fix no-useless-methods false-positive cases #77

igorkamyshev merged 3 commits into from
Dec 9, 2021

Conversation

@igorkamyshev
Copy link
Member

@igorkamyshev igorkamyshev commented Dec 9, 2021

fixes #74

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Total Coverage: 96.45%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Total Coverage: 96.45%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Total Coverage: 96.45%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 86.36% 100% 93.62% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 90% 100% 95.45% 120, 121, 145, 146, 92, 93
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-getState
   no-getState.js 91.67% 100% 96.15% 35, 36
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@igorkamyshev igorkamyshev merged commit 877de3b into master Dec 9, 2021
@igorkamyshev igorkamyshev deleted the fix-false-positive-no-useless-methods branch December 9, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive no-useless-method trigger

2 participants

@igorkamyshev