Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rule: strict-effect-handlers #78

Merged
merged 10 commits into from Dec 14, 2021
Merged

rule: strict-effect-handlers #78

merged 10 commits into from Dec 14, 2021

Conversation

igorkamyshev
Copy link
Member

@igorkamyshev igorkamyshev commented Dec 10, 2021 •
edited

fixes #39

  • TS-cases
  • imports
  • docs
  • tests for non-effect calls

@github-actions
Copy link

Total Coverage: 96.70%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 37, 38, 74, 75, 98, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.31% 119, 120, 144, 145, 91, 92
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 100% 100% 100%
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

Total Coverage: 96.71%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.48% 100, 38, 39, 75, 76, 99
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.31% 119, 120, 144, 145, 91, 92
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 100% 100% 100%
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70

@github-actions
Copy link

Total Coverage: 96.56%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 37, 38, 72, 73, 96, 97
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.24% 118, 119, 143, 144, 88, 89
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 100% 100% 100%
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70
rules/strict-effect-handlers
   strict-effect-handlers.js 87.50% 100% 94.12% 22, 23

@github-actions
Copy link

Total Coverage: 96.59%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 37, 38, 72, 73, 96, 97
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.24% 118, 119, 143, 144, 88, 89
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 100% 100% 100%
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70
rules/strict-effect-handlers
   strict-effect-handlers.js 75% 100% 95% 24, 25, 50, 58

@github-actions
Copy link

Total Coverage: 96.59%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 37, 38, 72, 73, 96, 97
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.24% 118, 119, 143, 144, 88, 89
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 100% 100% 100%
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70
rules/strict-effect-handlers
   strict-effect-handlers.js 75% 100% 95% 24, 25, 50, 58

@github-actions
Copy link

Total Coverage: 96.59%

Coverage Report
File Branch Funcs Lines Uncovered Lines
rules
rules/enforce-effect-naming-convention
   enforce-effect-naming-convention.js 85% 100% 93.33% 37, 38, 72, 73, 96, 97
rules/enforce-store-naming-convention
   enforce-store-naming-convention.js 89.29% 100% 95.24% 118, 119, 143, 144, 88, 89
rules/no-ambiguity-target
   no-ambiguity-target.js 100% 100% 100%
rules/no-duplicate-on
   no-duplicate-on.js 95.45% 100% 97.87% 32, 33
rules/no-getState
   no-getState.js 100% 100% 100%
rules/no-unnecessary-combination
   no-unnecessary-combination.js 85.71% 100% 96.77% 60, 64, 65
rules/no-unnecessary-duplication
   no-unnecessary-duplication.js 100% 100% 100%
rules/no-useless-methods
   no-useless-methods.js 100% 100% 100%
rules/no-watch
   no-watch.js 100% 100% 100%
rules/prefer-sample-over-forward-with-mapping
   prefer-sample-over-forward-with-mapping.js 78.57% 100% 89.66% 35, 36, 51, 52, 69, 70
rules/strict-effect-handlers
   strict-effect-handlers.js 75% 100% 95% 24, 25, 50, 58

@igorkamyshev igorkamyshev marked this pull request as ready for review December 14, 2021 07:54
@igorkamyshev igorkamyshev merged commit 91ed39b into master Dec 14, 2021
@igorkamyshev igorkamyshev deleted the strict-effect-handlers branch December 14, 2021 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rule: strict-effect-handlers
1 participant
@igorkamyshev