Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rule keep-options-order #81

Merged
merged 8 commits into from Dec 25, 2021
Merged

rule keep-options-order #81

merged 8 commits into from Dec 25, 2021

Conversation

igorkamyshev
Copy link
Member

@igorkamyshev igorkamyshev commented Dec 25, 2021

fixes #61

  • suggestion test-cases
  • rule implementation
  • suggestion implementation
  • imports
  • docs

@igorkamyshev
Copy link
Member Author

@sergeysova I remember, you've asked to add autofix to this rule. But personally, I'm little afraid of autofix because ESLint doesn't have any API for AST to source code transformation, so I do it manually and can break something in uncommon environments (e.g., FlowJS).

Should we replace suggestion by autofix? What do you think?

@igorkamyshev igorkamyshev marked this pull request as ready for review December 25, 2021 13:39
@igorkamyshev
Copy link
Member Author

So, I'm going to merge it, but we can still add autofix in separate PR.

@igorkamyshev igorkamyshev merged commit 2f11b1f into master Dec 25, 2021
@igorkamyshev igorkamyshev deleted the keep-options-order branch December 25, 2021 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule: keep-options-order
1 participant