Fix broken operation priorities for traced stores #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyaagarkov
added
bug
ilyaagarkov
commented
Sep 16, 2022
| before: scope.trace.before, | ||
| current: data, | ||
| }); | ||
| before = copy(scope.state.current) |
There was a problem hiding this comment.
I'm not sure how we should use previous value with createNode
zerobias
requested changes
Sep 16, 2022
sergeysova
changed the title
sergeysova
added
bug
zerobias
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have used pattern from patronum/debug for tracing store but not sure I did everything right
As I see this changes fix problems described here effector/logger#100