Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object arguments form for combineEvents #33

Closed
sergeysova opened this issue Jun 13, 2020 · 3 comments · Fixed by #58
Closed

Add object arguments form for combineEvents #33

sergeysova opened this issue Jun 13, 2020 · 3 comments · Fixed by #58
Assignees
Labels
enhancement Improvement in existing feature
Milestone

Comments

@sergeysova
Copy link
Contributor

sergeysova commented Jun 13, 2020

Should support config normalization

const event = combineEvents({
  events: { event1, event2, event3 }
});
@sergeysova sergeysova added the enhancement Improvement in existing feature label Jun 13, 2020
@sergeysova sergeysova added this to the 1.0 🦋 milestone Jun 13, 2020
@doasync
Copy link
Member

doasync commented Jun 18, 2020

How are you going to differentiate if the object (first param) is source or config?

@sergeysova
Copy link
Contributor Author

I want to remove the support of the previous configuration.
Leave just one — object form combineEvents({ events: {} })

@doasync
Copy link
Member

doasync commented Jun 26, 2020

Seems reasonable for combineEvents, as there is a need for reset and target options

@sergeysova sergeysova changed the title Add object form arguments for combineEvents Add object arguments form for combineEvents Jun 29, 2020
@sergeysova sergeysova self-assigned this Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement in existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants