Shallow types in machine so we can compile recursive data types. #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marzipankaiser
approved these changes
Sep 29, 2022
b-studios
reviewed
Sep 29, 2022
| @@ -212,7 +212,7 @@ object Transformer { | |||
| case lifted.BlockLit(params, body) => | |||
| // TODO deal with evidence | |||
| val parameters = params.map(transform); | |||
| val variable = Variable(freshName("g"), Negative(List(parameters.map(_.tpe)))) | |||
| val variable = Variable(freshName("g"), Negative("<function>")) | |||
There was a problem hiding this comment.
Functions don't need to be structural?
b-studios
approved these changes
Sep 29, 2022
|
I will go ahead and merge, so that you can proceed. We can still redesign it when we merge #132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.