Avoid having two effekt binaries (deprecate effekt.sh) #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
force-pushed
the
fix/effekt-cmd-on-linux
branch
from
7889f8f
to
f12a162
Compare
b-studios
changed the title
b-studios
changed the title
phischu
approved these changes
Oct 26, 2022
|
Looks like this has introduced a couple of regressions... We just got reports that it does break on Ubuntu 22.04. Also @JonathanStarup reported breakage on Windows. |
|
Maybe someone is curious to look into https://github.com/sbt/sbt-native-packager ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had to have two commands:
effektwhich worked on MacOseffekt.shwhich worked on Ubuntu systemsin #16 @waterlens proposes to use
-S(which is short for--split-string).I am not sure anymore, why I didn't do that in the first place. Maybe
-Sis not available on some implementations?Could someone with Ubuntu please try whether this works? Simply run
and then there should be
bin/effektwhich you probably need tochmod +xand then execute. Can you also try executing it with some arguments (like--help)?