Feature/mutable_state #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serkm
force-pushed
the
feature/mutable-state
branch
from
f1721c2
to
44430b0
Compare
serkm
force-pushed
the
feature/mutable-state
branch
from
b38eb8f
to
993da45
Compare
|
As soon as this branch is in a somewhat stable state, I would be happy to merge it. You can of course continue to work on it, but this way it is easier to deal with upstream changes (then you don't need to rebase so many commits every time master changes). |
and implement LLVM translation and rts
serkm
force-pushed
the
feature/mutable-state
branch
from
1dde4be
to
44b11c3
Compare
|
This is ready to merge now. |
b-studios
reviewed
Nov 24, 2022
| @@ -132,7 +132,7 @@ trait ChezScheme { | |||
| } | |||
| chez.Handle(handlers, toChez(body)) | |||
|
|
|||
| case Region(body) => chez.Builtin("with-region", toChez(body)) | |||
| case Region(body, _) => chez.Builtin("with-region", toChez(body)) | |||
There was a problem hiding this comment.
Ah I see that we also need the answer type here, yes!
b-studios
approved these changes
Nov 24, 2022
|
Thanks, good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.