Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from Scalatest to MUnit #172

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Move from Scalatest to MUnit #172

merged 1 commit into from
Nov 4, 2022

Conversation

b-studios
Copy link
Collaborator

Moving to munit has a few benefits:

  • the library itself is a lot simpler (and might be easier to get into for students)
  • the reported diffs for strings are much better (this is especially helpful, since we do a lot of golden-testing)
  • it comes with support for ANSI/windows normalized string comparison, which hopefully fixes check files are sensitive to CRLF / LF lineendings #168
  • it allows to filter easily based on the file name:
    image

There are also a few downsides:

  • tests cannot be grouped nicely anymore, like they was with scala tests describe. Instead I am using many different test suites, now.
  • do to the missing grouping, test output is not hierarchical anymore and might be harder to read.

For example, here is a run that shows munit:
image

previously, the tests were grouped by folders.

I am happy to accept these downsides. WDYT?

Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :shipit:

@b-studios b-studios merged commit 3f4998e into master Nov 4, 2022
@b-studios b-studios deleted the refactor/munit branch November 4, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check files are sensitive to CRLF / LF lineendings
3 participants