Feature/compile pattern matching #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
commented
Nov 14, 2022
| @@ -139,7 +139,7 @@ object Transformer { | |||
| case lifted.App(lifted.BlockVar(id), List(), args) => | |||
| // TODO deal with BlockLit | |||
| id match { | |||
| case symbols.UserFunction(_, _, _, _, _, _, _) => | |||
| case symbols.UserFunction(_, _, _, _, _, _, _) | symbols.TmpBlock(_) => | |||
There was a problem hiding this comment.
The matching here on symbols here is a smell. What is it that you really need here?
b-studios
commented
Nov 14, 2022
| }; | ||
| transform(scrutinee).run { value => | ||
| Switch(value, constructors.map { | ||
| constructor => clauses.find { _._1 == constructor } match { |
There was a problem hiding this comment.
This should not be necessary anymore, no?
There was a problem hiding this comment.
https://llvm.org/docs/LangRef.html#id39
switch i32 %val, label %otherwise [ i32 0, label %onzero
i32 1, label %onone
i32 2, label %ontwo ]
There was a problem hiding this comment.
The machine Switch just also needs a default label:
Currently:
case Switch(scrutinee: Variable, clauses: List[Clause])Proposed:
case Switch(scrutinee: Variable, clauses: List[(Int, Clause)], default: Clause)Note, that each clause also has an integer value.
There was a problem hiding this comment.
BTW, unsurprisingly, nested matching now also works in LLVM:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the weekend, I implemented a first draft of a match compiler. This should make life easier for all backend developers,
including LLVM (@phischu), JIT (@marzipankaiser), and MLTon (@JonathanStarup).
The match compiler is based on these notes by Jules Jacobs (@julesjacobs -- thanks a lot for these notes!):
https://julesjacobs.com/notes/patternmatching/patternmatching.pdf
Right now, the only implemented backend is JS (so LLVM and Chez are still missing for the tests to pass).