Drop intrinsic lists in core #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
commented
Nov 22, 2022
| def addToScope(definition: Definition, body: Stmt): Stmt = body match { | ||
| case Scope(definitions, body) => Scope(definition :: definitions, body) | ||
| case other => Scope(List(definition), other) | ||
| } |
There was a problem hiding this comment.
We use this helper function (for now) to not introduce too many Scopes in the translation.
b-studios
commented
Nov 22, 2022
|
|
||
| case Definition.Let(id, tpe, binding) => | ||
| js.Const(nameDef(id), toJS(binding)) | ||
| } |
There was a problem hiding this comment.
The refactoring bares first fruit.
b-studios
commented
Nov 22, 2022
| Def(id, tpe, transform(block)(using env, Context), rest) | ||
| case (core.Definition.Let(id, tpe, binding), rest) => | ||
| Let(id, tpe, transform(binding)(using env, Context), rest) | ||
| } |
There was a problem hiding this comment.
Here we go back to the horrible intrinsic lists, to refactor one bit at a time. :)
|
@phischu @marzipankaiser there is probably a better way to implement the translation to Machine. For now all LLVM tests go through. Maybe you could revise it? I propose the following:
WDYT? |
phischu
approved these changes
Nov 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge.
Using the intrinsic list encoding on core is really annoying on the module level, since a special return value usally unit has to be made up to terminate the list. This is a technical debt that we carry around for quite some time now,
As a step forward, here we
core.Definitioncore.Scopeto locally usecore.DefinitionScope(Scope...))core.Defintion.Mutualto separate out mutually recursive block definitionsList[Definition]instead ofStmtlifted.Completely unrelated to this PR, 7ff2ce2 also desugars while into a recursive function to further simplify core and lifted.