-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
machine: Fix passing of free variables to local functions #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marked as draft because this still does not work for:
Notes:
|
Since both the problem and the solution for #218 are closely related, I will fix that in this PR, too. |
Fixes #218 |
marzipankaiser
changed the title
machine: Fix computation of freeParams for local functions
machine: Fix passing of free variables to local functions
Jan 17, 2023
Now uses all free Ids minus block labels and constructor names. Also adds a minor fix to transform(BlockType).
Since they are labels in the machine code, not codata.
The example was found by shrinking the nqueens benchmark.
They are treated specially in machine
marzipankaiser
force-pushed
the
bugfix/issue217
branch
from
February 23, 2023 15:31
68e05d1
to
aad8383
Compare
@phischu This is what we talked about back then. Since it is now rebased and working, I will just merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this uses all free Ids minus block labels, the name of this definition and constructor names,
and also adds the free Ids of called functions.
This also eta-expands functions passed directly as block parameters (since they are labels and thus, this will never work).
Additionally, adds a minor bugfix to
transform(BlockType)
.Resolves #217.