Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Holes to machine and llvm #220

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

marzipankaiser
Copy link
Contributor

When executed, a hole will print a generic error message and exit with exit code 1.

@marzipankaiser marzipankaiser added feature New feature or request area:llvm labels Jan 17, 2023
@b-studios
Copy link
Collaborator

Can we also desugar holes into a primitive call instead of a separate syntax object?

@marzipankaiser
Copy link
Contributor Author

You mean in machine already? Or even earlier?

@b-studios
Copy link
Collaborator

Right now I was thinking of Machine; but maybe even as early as core?

@marzipankaiser
Copy link
Contributor Author

Then, we would have to somehow get at the symbol of the builtin. 🤔
Also, this might make it harder to implement some backend-specific behaviours for holes (e.g. if we would ever compile to a target that has support for holes, it would be nice if we could just use that).

I don't know what's the better solution, I think that - for now - this is more consistent with the other parts (core, lifted), though.

@b-studios
Copy link
Collaborator

Ok, I don't have a strong preference since it is easily changed.

When executed, a hole will print a generic error and exit with exit code
1.
@marzipankaiser
Copy link
Contributor Author

Requested review mostly fyi. Will now merge.

@marzipankaiser marzipankaiser merged commit 430373b into master Feb 23, 2023
@b-studios b-studios deleted the feature/machine-holes branch January 28, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:llvm feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants