Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve errors #255

Merged
merged 5 commits into from
Apr 11, 2023
Merged

Improve errors #255

merged 5 commits into from
Apr 11, 2023

Conversation

b-studios
Copy link
Collaborator

@b-studios b-studios commented Apr 7, 2023

In this PR I try to address a few issues that are all concerned with error messages and warnings issued by the Effekt compiler. In particular, these are:

A few of them should be solved with this PR, a few others are solved "for now" (while there are better solutions).

@b-studios b-studios requested a review from jiribenes April 7, 2023 19:45
@b-studios
Copy link
Collaborator Author

Commit 3da0288 also address #145

@b-studios
Copy link
Collaborator Author

@jiribenes Since many of the above issues are authored by you, it would be valuable if you could review this PR.

@b-studios b-studios marked this pull request as ready for review April 9, 2023 18:10
Copy link
Contributor

@jiribenes jiribenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for these improvements! 👍

effekt/shared/src/main/scala/effekt/Typer.scala Outdated Show resolved Hide resolved
Co-authored-by: Jiří Beneš <mail@jiribenes.com>
@b-studios b-studios merged commit 3a1cded into master Apr 11, 2023
0 of 2 checks passed
@b-studios b-studios deleted the improve-errors branch April 11, 2023 09:20
jiribenes added a commit that referenced this pull request Apr 11, 2023
b-studios pushed a commit that referenced this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants