-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement pattern matching with literals and guards #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-studios
changed the title
Implement proposal #383 in frontend to ease discussion
Implement pattern matching with guards
Feb 2, 2024
Reminder to future me: Hey Jonathan, nice that you have some time for programming again; if you really want to add Or-Patterns again, start by reverting d4452a3. |
To fix in the future: Using |
b-studios
changed the title
Implement pattern matching with guards
Implement pattern matching with literals and guards
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements proposal #383. A working example can be found here:
Notes about the implementation can be found at the top of
PatternMatchingCompiler.scala
ExhaustivityChecker.scala
The implementation of the compiler was rather modest; exhaustivity checking was surprisingly tricky since it is difficult to maintain the necessary information (like types to check exhaustivity of nested scrutinees).
Both implementations (compiler and checker) are structure to
Context
)Context
and can thus be tested more easily)Note: for now, I decided that Or-Patterns are not worth it.
Implemented in frontend
- [x] or patterns (properly, which requires significant changes to always bind the SAME symbol)pattern compiler
- [ ] or patterns- [ ] fuse subsequent predicates using&&
but also make&&
by-name in its arguments.translation