Fix the build with slibtool #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orbea
added a commit
to orbea/gentoo
that referenced
this pull request
May 9, 2022
When building with slibtool the build fails with many multiple definition errors. This is because of overlinking internal .la files where GNU libtool somehow obscures the issue. Note the newer Babeltrace 2 which is not yet in Gentoo does not seem to have any slibtool related build issues. Bug: https://bugs.gentoo.org/777444 Upstream-PR: efficios/babeltrace#119 Signed-off-by: orbea <orbea@riseup.net>
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
May 9, 2022
When building with slibtool the build fails with many multiple definition errors. This is because of overlinking internal .la files where GNU libtool somehow obscures the issue. Note the newer Babeltrace 2 which is not yet in Gentoo does not seem to have any slibtool related build issues. Bug: https://bugs.gentoo.org/777444 Upstream-PR: efficios/babeltrace#119 Closes: #25408 Signed-off-by: orbea <orbea@riseup.net> Signed-off-by: Yixun Lan <dlan@gentoo.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gentoo bug: https://bugs.gentoo.org/777444
Note:
stable-1.5branch.masterbranch is not affected.The Babeltrace 1 build fails when using slibtool (https://dev.midipix.org/cross/slibtool) instead of GNU libtool with many multiple definition warnings. This appears to be a case of overlinking and can be solved by cleaning up the
.ladependencies for the build. Slibtool is more sensitive to user error while GNU libtool will silently hide some of the worst bugs which is how this goes unnoticed. With this patch it now works with both slibtool and GNU libtool on my system. I am not sure if you wish to carry this patch too, but I am sharing it in case you find it valuable.