copy over icon name and author when upgrading document versions

effortlessmountain · Apr 19, 2020 · 067901a · 067901a
1 parent 948d8e1
commit 067901a
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 3 deletions.
diff --git a/public/index.html b/public/index.html
@@ -41,7 +41,7 @@ <h3>How do I add an icon to my asset?</h3>
     <div class="container">
         <div class="assets"></div>
         <div class="interface">
-            <h2>Ironsworn Asset Workbench v0.6.0</h2>
+            <h2>Ironsworn Asset Workbench v0.6.1</h2>
             <div class="top-row-controls">
                 <div>
                     <label>Scale (also affects Download size)</label>

diff --git a/src/schema.test.ts b/src/schema.test.ts
@@ -157,6 +157,18 @@ describe("transforming from schema v1 to v2", () => {
                 viewBox: "0 0 512 512"
             }
 
+            test("name gets copied over", () => {
+                const result = transformToLatest(createV1Asset())
+
+                expect((result.icon as SvgIcon).name).toBe((v2Asset.icon as SvgIcon).name)
+            })
+
+            test("author gets copied over", () => {
+                const result = transformToLatest(createV1Asset())
+
+                expect((result.icon as SvgIcon).author).toBe((v2Asset.icon as SvgIcon).author)
+            })
+
             const svgProperties = ["d", "fill", "fillOpacity", "viewBox"]
 
             svgProperties.forEach((prop) => {

diff --git a/src/schema.ts b/src/schema.ts
@@ -105,8 +105,8 @@ function transformToV2(v1: AssetDocumentV1): AssetDocumentV2 {
     } else if (typeof v1.icon === "object") {
         v2.icon = {
             type: "svg",
-            author: "",
-            name: "",
+            author: v1.icon.author,
+            name: v1.icon.name,
             svg: transformSvgString(v1.icon.svg)
         }