Draft: java 11 support #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turmio
commented
Apr 4, 2023
There was a problem hiding this comment.
This PR also includes some of https://github.com/eficode/JavaFXLibrary/tree/java-11-support branch solutions and has solutions to unresolved issues in that branch.
| @@ -50,7 +53,7 @@ public void getMouseButtons_MultipleValues() { | |||
| public void getMouseButtons_InvalidValue() { | |||
| thrown.expect(JavaFXLibraryNonFatalException.class); | |||
| // thrown.expect(IllegalArgumentException.class); | |||
| thrown.expectMessage("\"HUGE_RED_ONE\" is not a valid MouseButton. Accepted values are: [NONE, PRIMARY, MIDDLE, SECONDARY]"); | |||
| thrown.expectMessage("\"HUGE_RED_ONE\" is not a valid MouseButton. Accepted values are: " + Arrays.asList(MouseButton.values())); | |||
There was a problem hiding this comment.
I had a mouse with back and forward buttons. Test failed since message had BACK and FORWARD values.
| @@ -391,7 +424,7 @@ | |||
| <dependency> | |||
| <groupId>org.testfx</groupId> | |||
| <artifactId>openjfx-monocle</artifactId> | |||
| <version>8u76-b04</version> | |||
| <version>jdk-12.0.1+2</version> | |||
There was a problem hiding this comment.
jdk-11+26 version did not work. Had some missing methods. Upgrading resolved issues.
| @@ -128,6 +128,8 @@ public JavaFXLibrary(boolean headless) { | |||
| if (headless) { | |||
| System.setProperty("testfx.robot", "glass"); | |||
| System.setProperty("testfx.headless", "true"); | |||
| System.setProperty("glass.platform", "Monocle"); | |||
| System.setProperty("monocle.platform", "Headless"); | |||
There was a problem hiding this comment.
Relates to previous comment. Maybe these are not necessary?
| RobotLog.info("Index number: " + i); | ||
| columnCells.add(mapObject(vf.getCell(i).getChildrenUnmodifiable().get(column))); | ||
| } | ||
| Optional<VirtualFlow> vf = table.getChildrenUnmodifiable().stream().filter(node -> node instanceof VirtualFlow).map(VirtualFlow.class::cast).findFirst(); |
There was a problem hiding this comment.
Changed public API in JavaFX.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Java 11 support. Currently tested on Windows machine so may need some extra work on other machines. CI is not fixed yet.
Implements #23