Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http authentication #8

Merged
merged 5 commits into from
Jun 2, 2021
Merged

Conversation

ot2789
Copy link

@ot2789 ot2789 commented May 28, 2021

PR request created according to discussion:
asyrjasalo#115

@asimell
Copy link

asimell commented May 31, 2021

Hi @ot2789 !

Looks like suite automated tests failed with Python 3.6 and Python 3.7:

TypeError: Object of type 'HTTPBasicAuth' is not JSON serializable

Could you take a look?

@ot2789
Copy link
Author

ot2789 commented May 31, 2021

Hi @ot2789 !

Looks like suite automated tests failed with Python 3.6 and Python 3.7:

TypeError: Object of type 'HTTPBasicAuth' is not JSON serializable

Could you take a look?

Yeah. I did a small change in the Rest Instances keyword. Check again.

@ot2789
Copy link
Author

ot2789 commented Jun 2, 2021

@asimell Any updates on this?

Copy link

@asimell asimell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Atihinen any comments?

@Atihinen Atihinen self-requested a review June 2, 2021 08:44
Copy link
Member

@Atihinen Atihinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Atihinen Atihinen merged commit 0b25bb8 into eficode:master Jun 2, 2021
@ot2789
Copy link
Author

ot2789 commented Jun 2, 2021

Edit: Thanks for the merge!
@asimell
Is there a way to install the master of this RESTinstance through pip?

@asimell
Copy link

asimell commented Jun 2, 2021

@ot2789 Not currently. We have a roadmap for the next release. We try to squeeze a bit more stuff into this release before making the release. The release will hopefully be available within few weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants