Config options, solution 2 (fixes #2)

[matejc]

add specific-to-handler config options to override config entries

[Tattoo]

Few changes more, if you would be kind :)

still some work to do

[Tattoo]

This is one of the critical parts to understand from the test case and thus, it's very weird that it's not in the context of code, but outside of it in a decorator.

Also, needing to scroll up to see base_args is bit cumbersome, where it could be in the context of the code

patch.object() can be used as a context manager (example from mock documentation):

with patch.object(ProductionClass, 'method', return_value=None) as mock_method:
    thing = ProductionClass()
    thing.method(1, 2, 3)

mock_method.assert_called_once_with(1, 2, 3)

So in other words, something like this would be nice:

@patch('oxygen.oxygen.RobotInterface')
def test_cli_no_optional_arguments(self, mock_robot_iface):
     cmd = f'oxygen oxygen.zap {self.ZAP_XML}'  # here you can see what the actual command is
     with patch.object(sys, 'argv', cmd.split()):  
         self.cli.run()

    self.assertEquals(self.handler._config['accepted_risk_level'], 2)
    self.assertEquals(self.handler._config['required_confidence_level'], 1)

[Tattoo]

This repeats in all tests, thus should be in setUp()

[Tattoo]

What's the point of these verifications? As far as I can see, the test is not interested in these details -- it seems they are just copy-paste?

[Tattoo]

The pep8-compliant ordering should be:

Suggested change

	from ..helpers import RESOURCES_PATH
	from oxygen.oxygen import OxygenCLI
	from robot.running.model import TestSuite
	from unittest import TestCase
	from unittest.mock import ANY, create_autospec, Mock, patch
	import sys
	import sys
	from unittest import TestCase
	from unittest.mock import ANY, create_autospec, Mock, patch
	from robot.running.model import TestSuite
	from oxygen.oxygen import OxygenCLI
	from ..helpers import RESOURCES_PATH

To explain:

# first come imports from standard library
# and first of them, imports of full modules
import sys  
# and then "from ... import"s
from unittest import TestCase  
from unittest.mock import ANY, create_autospec, Mock, patch

# we also leave one empty line to denote to others that "section" of imports has changed

# then come imports from 3rd party modules
from robot.running.model import TestSuite

# another empty line to denote "section"

# then come imports from local code
from oxygen.oxygen import OxygenCLI
# with relative imports being last because they are the 'closest' 
from ..helpers import RESOURCES_PATH

[Tattoo]

Excellent work 💖 '

[Tattoo]

fixes #2