show version with `-v` or `--version` option #71

philipp-kunz-mimacom · 2021-11-29T18:57:10Z

No description provided.

Addono

Hey! Thanks for the PR.

So, since bumping the version and generating the release not is handled automatically by semantic-release, having it hardcoded will for sure get out of sync at some point.

Actually someone at Google had exactly the same issue, and from that they created a plugin for semantic-release to automate that bit:
https://github.com/google/semantic-release-replace-plugin

Addono · 2021-11-29T19:41:33Z

CHANGELOG.md

+### Features
+
+* show version with `-v` or `--version` option
+


No need to touch CHANGELOG.md, it will be generated automatically based on your commit message.

Suggested change

### Features

* show version with `-v` or `--version` option

Addono · 2021-11-29T19:41:57Z

wait-for

@@ -141,6 +142,10 @@ while :; do
    TIMEOUT="${1#*=}"
    shift 1
    ;;
+    -v | --version)
+    echo 2.1.3


Keeping this version in check should be automated, e.g. using https://github.com/google/semantic-release-replace-plugin.

Addono · 2021-11-29T19:42:54Z

wait-for.bats

+@test "support version option" {
+  run ./wait-for -v
+
+  [ "$output" = "2.1.3" ]


Maybe here we could check if the output is in sync with the version stated in package.json 🤷

Just to make sure that our version-bump logic succeeded.

…-kunz-mimacom

…-kunz-mimacom) Based on PR #71.

@philipp-kunz-mimacom

# [2.2.0](v2.1.3...v2.2.0) (2021-11-29) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [#71](#71)

Addono · 2021-11-29T20:22:30Z

Hey! I figured I had some time left today and made the suggested changes myself such that it can hit master ASAP. 😄

Fyi, the commit which landed this feature is here:
8636f50

Thank you soo much for the PR ❤️ , it's definitely a good idea to have a way to keep track of which version of the script you're dealing with!

philipp-kunz-mimacom · 2021-11-30T06:48:28Z

@Addono , you're a genius

@philipp-kunz-mimacom

# [2.2.0](v2.1.3...v2.2.0) (2021-12-13) ### Bug Fixes * pull image ([f3e580d](f3e580d)) * pull image ([0198f77](0198f77)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/philipp-kunz-mimacom/wait-for/issues/71)

@philipp-kunz-mimacom

# [2.2.0](v2.1.3...v2.2.0) (2022-01-03) ### Bug Fixes * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/philipp-kunz-mimacom/wait-for/issues/71)

@philipp-kunz-mimacom

# 1.0.0 (2022-02-06) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [#16](#16) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/Shingaz/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/Shingaz/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [#14](#14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2022-03-11) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [#16](#16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/Penbase/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/Penbase/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/Penbase/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [#14](#14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([4b9b12e](4b9b12e)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([4b9b12e](4b9b12e)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2022-12-21) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2023-01-08) ### Bug Fixes * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/gesellix/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/gesellix/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/gesellix/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/gesellix/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/gesellix/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2023-06-02) ### Bug Fixes * `wget` in alpine runs into an endless retry loop ([eficode#100](https://github.com/danieleagle/wait-for/issues/100)) ([b15c461](b15c461)) * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/danieleagle/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/danieleagle/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/danieleagle/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/danieleagle/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/danieleagle/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

@philipp-kunz-mimacom

# 1.0.0 (2023-12-09) ### Bug Fixes * `wget` in alpine runs into an endless retry loop ([eficode#100](https://github.com/fitz7/wait-for/issues/100)) ([b15c461](b15c461)) * **command:** Restore environment variables before calling `exec` ([c7631e5](c7631e5)) * correctly render the command name in the help text ([d2bbce7](d2bbce7)), closes [eficode#16](https://github.com/fitz7/wait-for/issues/16) * **http:** corrects protocol check for wget availability ([eficode#82](https://github.com/fitz7/wait-for/issues/82)) ([570c9fb](570c9fb)) * **iteration:** Remember to try one last time before giving up ([2ed5308](2ed5308)) * **timeout:** resolve degredation which prevented setting indefinite timeout ([b45e76c](b45e76c)) * typo in error message for missing wget command ([db2479e](db2479e)) * uses timeout in nc as it is used with wget ([eficode#42](https://github.com/fitz7/wait-for/issues/42)) ([0195167](0195167)) * wget timeout does not double ([206b38d](206b38d)) ### Features * adds -v and --version flag to show the version (Thanks [@philipp-kunz-mimacom](https://github.com/philipp-kunz-mimacom)) ([8636f50](8636f50)), closes [eficode#71](https://github.com/fitz7/wait-for/issues/71) * adds license header to wait-for script ([975d508](975d508)) * adds support for http using wget ([ff0d29d](ff0d29d)), closes [eficode#14](https://github.com/fitz7/wait-for/issues/14) * **option:** Restrict the timeout input to non-negative integers ([c4d125f](c4d125f)) * **option:** Support more conventional formats in the option parser ([ce95717](ce95717)) * **version:** trigger first release for v1.0.0 ([33f1343](33f1343)) ### BREAKING CHANGES * **command:** HOST, PORT and other internally used environment variables are not overwritten anymore. If you use these, then you need to manually supply them.

feat(option): show version with -v or --version option

e64349d

philipp-kunz-mimacom force-pushed the feature/version branch from d5b03e3 to e64349d Compare November 29, 2021 19:05

Addono requested changes Nov 29, 2021

View reviewed changes

Addono added the enhancement label Nov 29, 2021

Addono added a commit that referenced this pull request Nov 29, 2021

feat: adds -v and --version flag to show the version (Thanks @philipp…

8636f50

…-kunz-mimacom) Based on PR #71.

Addono closed this Nov 29, 2021

philipp-kunz-mimacom deleted the feature/version branch December 22, 2021 15:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

show version with `-v` or `--version` option #71

show version with `-v` or `--version` option #71

philipp-kunz-mimacom commented Nov 29, 2021

Addono left a comment

Addono Nov 29, 2021

Addono Nov 29, 2021

Addono Nov 29, 2021

Addono commented Nov 29, 2021

philipp-kunz-mimacom commented Nov 30, 2021 •

edited

Loading

show version with -v or --version option #71

show version with -v or --version option #71

Conversation

philipp-kunz-mimacom commented Nov 29, 2021

Addono left a comment

Choose a reason for hiding this comment

Addono Nov 29, 2021

Choose a reason for hiding this comment

Addono Nov 29, 2021

Choose a reason for hiding this comment

Addono Nov 29, 2021

Choose a reason for hiding this comment

Addono commented Nov 29, 2021

philipp-kunz-mimacom commented Nov 30, 2021 • edited Loading

show version with `-v` or `--version` option #71

show version with `-v` or `--version` option #71

philipp-kunz-mimacom commented Nov 30, 2021 •

edited

Loading