Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICalendarParser crashes on ESP32 but not when testing on PC #1

Closed
loulecrivain opened this issue Nov 1, 2018 · 2 comments
Closed

ICalendarParser crashes on ESP32 but not when testing on PC #1

loulecrivain opened this issue Nov 1, 2018 · 2 comments
Assignees
@loulecrivain
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@loulecrivain
Copy link
Collaborator

Here is decoded backtrace
trace3
I can't get the testing program to crash on PC, even when enabling -fstack-protector-all with g++
@loulecrivain loulecrivain added the bug Something isn't working label Nov 1, 2018
@loulecrivain loulecrivain self-assigned this Nov 1, 2018
@loulecrivain loulecrivain added the help wanted Extra attention is needed label Nov 3, 2018
@loulecrivain
Copy link
Collaborator Author

Ok bug seems to be in ICline::setFromICString function. It seems to be the only one modifying stack values (ic_curline object).

@loulecrivain
Copy link
Collaborator Author

Issue was fixed by commit 09bc555.
We think that the stack-protector wasn't triggered on PC because it was overwritten with the same values it already has (see https://en.wikipedia.org/wiki/Stack-smashing_protection#Terminator_canaries)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loulecrivain loulecrivain

Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@loulecrivain