Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clean really clean in src/ #114

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Conversation

jpellegrini
Copy link
Contributor

  • Remove git-info.h, not git-config.h
  • Also remove boot.ok
  • And fix the comment in Makefile.am

* Remove git-info.h, not git-config.h
* Also remove boot.ok
* And fix the comment in Makefile.am
@egallesio
Copy link
Owner

Hi @jpellegrini,

Imho, boot.ok should not be deleted. It is the last boot file which is know to work. This is particulary useful if you have a bug in boot.img. Restarting from a too mush old image can also be a problem, and force you to unset a bunch of modification you have done in one of the intervening files in the boot process. It served me more than one time, trust me.

Of course, committing often in the git tree minimizes the utility to keep it, but it is a good safety belt to prevent long rollbacks. Is it really a problem to keep it?

@jpellegrini
Copy link
Contributor Author

Hm, ok. Actually, the Debian package expects the clean target to delete it, but this is not a problem -- it can be done ad-hoc in debian/rules.

@egallesio egallesio merged commit b856858 into egallesio:master Sep 21, 2020
@egallesio
Copy link
Owner

Hi,
I have renamed the file boot.ok in boot.keep. However, instead of deleting is now done when doing a make distclean (instead of a make clean as done in this PR). I don't know if will be OK for Debian, but as I said before, it is important to keep this file to be able to backtrack when the boot image is broken. I suppose you'll have to modify the debian/rules file.

@jpellegrini jpellegrini deleted the cleanup branch May 18, 2022 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants