Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sphinx's version pin + migrate to hatchling #9

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Conversation

egeakman
Copy link
Owner

No description provided.

@egeakman egeakman added the enhancement New feature or request label Jan 22, 2024
@egeakman egeakman changed the title Migrate to hatch Remove sphinx's version pin + migrate to hatchling Jan 22, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: The pull request introduces a series of refactoring changes aimed at improving the maintainability and readability of the codebase. It includes the consolidation of data directory paths within the bootstrapper module, updates to the pre-commit configuration, and the addition of versioning information in the bootstrapper's init file.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that path handling is consistent and robust across different operating systems by using the appropriate path joining methods provided by os.path or pathlib.
  • Consider the implications of removing explicit names and additional dependencies in the pre-commit configuration to maintain clarity and functionality.
  • Review the practice of storing the version number within the __init__.py file, as it might be beneficial to keep it in a separate file for easier management.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

bootstrapper/bootstrapper.py Show resolved Hide resolved
bootstrapper/bootstrapper.py Show resolved Hide resolved
bootstrapper/__init__.py Show resolved Hide resolved
bootstrapper/bootstrapper.py Show resolved Hide resolved
.pre-commit-config.yaml Show resolved Hide resolved
@egeakman egeakman merged commit 5adbefd into main Jan 22, 2024
26 checks passed
@egeakman egeakman deleted the hatch branch January 22, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant