append colon to encoded polylines in distance matrix query #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egeloen
reviewed
Jun 8, 2017
| @@ -504,7 +505,7 @@ public function setLanguage($language = null) | |||
| public function buildQuery() | |||
| { | |||
| $locationBuilder = function (LocationInterface $location) { | |||
| return $location->buildQuery(); | |||
| return $location->buildQuery() . ($location instanceof EncodedPolylineLocation ? ':' : ''); | |||
There was a problem hiding this comment.
Hum, can't you make it part of the buildQuery method of the EncodedPolylineLocation? This way not need for the instanceof check :)
There was a problem hiding this comment.
@egeloen That's what I initially did but then tests for some other services failed so I came with this solution.
There was a problem hiding this comment.
@dergus Ok, I will give a try to your branch and look why it's not working (IMO, it is related to the API key used by the tests (which has been revoked).
egeloen
force-pushed
the
encoded_polyline_colon_bug_v2
branch
19 times, most recently
from
4685390
to
fa24e4e
Compare
egeloen
force-pushed
the
encoded_polyline_colon_bug_v2
branch
from
fa24e4e
to
79455e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #240