Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow usage with Monolog 2 #4

Merged
merged 1 commit into from
May 30, 2022
Merged

Conversation

rimas-kudelis
Copy link
Contributor

@rimas-kudelis rimas-kudelis commented May 30, 2022

Additionally:

  • the processors now implement ProcessorInterface
  • PHPUnit dependency updated to ^8.5 (^9.5 requires additional changes)
  • Travis configured to build with currently supported PHP versions
  • composer.lock has been removed

Fixes #3

Additionally:
- the processors now implement ProcessorInterface
- PHPUnit dependency updated to ^8.5 (^9.5 requires additional changes)
- Travis configured to build with currently supported PHP versions
- composer.lock has been removed
@rimas-kudelis
Copy link
Contributor Author

rimas-kudelis commented May 30, 2022

@andriesss would you mind reviewing this and tagging a new release if all is good?

@andriesss
Copy link
Collaborator

Thanks @rimas-kudelis! Why did you remove the composer.lock file?

@rimas-kudelis
Copy link
Contributor Author

rimas-kudelis commented May 30, 2022

@andriesss this is a library, what's the point of locking its dependencies? That lock will be ignored when installing this package as a dependency anyway.

Furthermore, should you decide to configure testing dependencies as a matrix (e.g. not just PHP 7.4, 8.0 and 8.1, but instead combinations of these PHP versions with Monolog 1 and 2), composer.lock would probably just get in the way of that.

@andriesss andriesss merged commit f092f83 into egeniq:develop May 30, 2022
@rimas-kudelis
Copy link
Contributor Author

Also notably, Monolog 3 has been released recently. I haven't added it as a supported dependency, because it uses LogRecord objects instead of arrays. Although it seems that that class implements ArrayAccess for BC, so it might just work with extra typehints.

@rimas-kudelis
Copy link
Contributor Author

@andriesss, Packagist says that "This package is not auto-updated.". Could you ping Packagist as well (or just configure automatic updating)? Thanks!

@andriesss
Copy link
Collaborator

@rimas-kudelis done.

@rimas-kudelis
Copy link
Contributor Author

@andriesss thanks! Also, Travis-CI no longer builds anything on travis-ci.org, so the badge in the README is now misleading.

@andriesss
Copy link
Collaborator

@rimas-kudelis could you give me some pointers on how to fix that? It's been a while since I've last used Travis.

@rimas-kudelis
Copy link
Contributor Author

@andriesss sure, see #5 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update monolog dependencies
2 participants