Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Velocity errors #19

Closed
SageThrower opened this issue Jun 14, 2019 · 3 comments
Closed

Velocity errors #19

SageThrower opened this issue Jun 14, 2019 · 3 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@SageThrower
Copy link

Today i tried installing your plugins but both are not working, and i do not now why.
I am currently using Velocity #149 on a Ubuntu 18.04 LTS os with openjdk version "1.8.0_212" as the java runtime

Here is the server log: https://rentry.co/t6e86

Hope this helps you since i would really like to try out your plugins :)

@egg82 egg82 added the bug Something isn't working label Jun 15, 2019
@egg82
Copy link
Collaborator

egg82 commented Jun 15, 2019

okay, so this is a tiny bit strange, but..
these plugins use Aikar's ACF for command handling. Problem is, the Velocity module for this library accidentally includes the entirety of (an older version) of Velocity which hasn't yet updated to Kyori text version 3 like the release version of Velocity has.
So, when this plugin downloads and injects ACF into its ClassLoader container it also injects an older version of the entire Velocity API and tries to use that instead of the actual server.

The good news:
I made a PR to ACF here which fixes this issue entirely. The moment that PR is merged and the snapshot is updated on Aikar's repo, the plugin will automatically download and use the new version of that library without you or I needing to do any updating or maintenance at all. Magical!
So, do me and everyone else a favor and help me get that PR merged and an updated version on Aikar's repository ;)

@egg82 egg82 added the wontfix This will not be worked on label Jun 15, 2019
@egg82
Copy link
Collaborator

egg82 commented Jun 15, 2019

Labeling as "wontfix" because I can't do any more to solve this issue by myself and I won't need to update the plugin once the new version of that library is released anyway.

@egg82 egg82 closed this as completed Jun 15, 2019
@egg82
Copy link
Collaborator

egg82 commented Jun 18, 2019

As an aside, for now you can download a version I built from that branch and replace the current file in AntiVPN/external

https://files.egg82.ninja/download.php?id=2&token=idwqSTekMGmSXTJ6uoYAYjYfES1kqK6B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants