Updated Velocity to latest#216
Merged
Merged
Conversation
added 2 commits
June 10, 2019 20:41
Kyori text is the only breaking change, here.
Contributor
Author
|
Heads-up, Velocity officially releases its first version today (woo!) - would be good to have this updated and working for the release. |
|
@aikar can you merge this? |
js6pak
reviewed
Jun 21, 2019
| @SuppressWarnings("deprecation") | ||
| String format(TextColor color, String message) { | ||
| return ComponentSerializers.LEGACY.serialize(ComponentSerializers.LEGACY.deserialize(message).color(color)); | ||
| return LegacyComponentSerializer.legacy().serialize(LegacyComponentSerializer.legacy().deserialize(message).color(color)); |
There was a problem hiding this comment.
Shouldn't you use LegacyComponentSerializer.INSTANCE like in kyori.text sample?
There was a problem hiding this comment.
LegacyComponentSerializer.INSTANCE was deprecated with LegacyComponentSerializer.legacyLinking() becoming an option (which makes LegacyComponentSerializer act more like the BungeeCord chat API and CraftBukkit).
aikar
approved these changes
Jun 21, 2019
|
When this will be available on repo? @aikar |
Collaborator
|
@js6pak I have deployed it for you. Sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kyori text was the only thing needing updating.
I don't know why you're using tabs in the pom.xml, but I tried to keep it as best as possible. Intellij doesn't like them much.