Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Velocity to latest #216

Merged
merged 2 commits into from Jun 21, 2019

Conversation

Projects
None yet
5 participants
@egg82
Copy link
Contributor

commented Jun 11, 2019

Kyori text was the only thing needing updating.

I don't know why you're using tabs in the pom.xml, but I tried to keep it as best as possible. Intellij doesn't like them much.

egg82 added some commits Jun 11, 2019

Updated Velocity to latest
Kyori text is the only breaking change, here.
@egg82

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Heads-up, Velocity officially releases its first version today (woo!) - would be good to have this updated and working for the release.

@egg82 egg82 referenced this pull request Jun 15, 2019

Closed

Velocity errors #19

@js6pak

This comment has been minimized.

Copy link

commented Jun 21, 2019

@aikar can you merge this?

@@ -12,6 +12,6 @@ public VelocityMessageFormatter(TextColor... colors) {
@Override
@SuppressWarnings("deprecation")
String format(TextColor color, String message) {
return ComponentSerializers.LEGACY.serialize(ComponentSerializers.LEGACY.deserialize(message).color(color));
return LegacyComponentSerializer.legacy().serialize(LegacyComponentSerializer.legacy().deserialize(message).color(color));

This comment has been minimized.

Copy link
@js6pak

js6pak Jun 21, 2019

Shouldn't you use LegacyComponentSerializer.INSTANCE like in kyori.text sample?

This comment has been minimized.

Copy link
@astei

astei Jun 22, 2019

LegacyComponentSerializer.INSTANCE was deprecated with LegacyComponentSerializer.legacyLinking() becoming an option (which makes LegacyComponentSerializer act more like the BungeeCord chat API and CraftBukkit).

@js6pak js6pak referenced this pull request Jun 21, 2019

Merged

Update to Velocity 1.0.0 #135

@aikar

aikar approved these changes Jun 21, 2019

@aikar aikar merged commit 96e5414 into aikar:master Jun 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@js6pak

This comment has been minimized.

Copy link

commented Jun 22, 2019

When this will be available on repo? @aikar

@chickeneer

This comment has been minimized.

Copy link
Collaborator

commented Jun 23, 2019

@js6pak I have deployed it for you. Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.