[solved]custom configurations ignored...cant set dialog to "force"

[xstar97]

I tried multiple ways & even followed the sample to the letter, but I can't set my dialog to "force" so I can finally "force" my users to install the latest updates....it keeps using the default settings...the two button dismiss & update!
this is the only library that worked for me & its the simplest...but it just won't let me set my own configurations what so ever

I also even changed my json file from version name to versioncode just to be sure...but its still the same problem

[mikemee]

Thanks Xstar97, We'll take a look at this pronto. Just in case it helps, do you have a code snippet you can share? Thx.

[mikemee]

Fwiw, I created the screenshots by using the various options, so it was working to some extent...

[mikemee]

@yurii-diachenko can you please take a look, and also create a test to cover the FORCE scenario (and similar)? Thx.

[xstar97]

//above oncreate
private static final String TAG = MainActivity.class.getSimpleName();
private static final String SIREN_JSON_DOCUMENT_URL = "https://raw.githubusercontent.com/Xstar97/TXI/master/gandalf.json";
//inside on create
checkCurrentAppVersion();
....
}

private void checkCurrentAppVersion() {
    Siren siren = Siren.getInstance(getApplicationContext());
    siren.setMajorUpdateAlertType(SirenAlertType.FORCE);
    siren.checkVersion(this, SirenVersionCheckType.IMMEDIATELY, SIREN_JSON_DOCUMENT_URL);
}

[mikemee]

@xstar97, and what is the current version of your app? I wonder if adding the following will get the bahaviour you want:

siren.setMajorUpdateAlertType(SirenAlertType.FORCE);
siren.setMinorUpdateAlertType(SirenAlertType.FORCE);
siren.setPatchUpdateAlertType(SirenAlertType.FORCE);
siren.setRevisionUpdateAlertType(SirenAlertType.FORCE);

In the meantime, we'll check the logic for Major when using minVersionCode in the json file. Thx.

[xstar97]

The version Code is 4, but my json states 5 for testing purposes

[xstar97]

its still the same...config is still not working me...is it working with you?

[xstar97]

private static final String TAG = MainActivity.class.getSimpleName();

in this line "TAG" is yellow...does this have any merit in the error or no?

[xstar97]

also I cant add any older version to my build.gradle...in aide

[mikemee]

Thanks for that extra info. I've replicated this behaviour. Now I'm trying to work out why it's broken. I expect to update here shortly... though my laptop battery is running out...!

[xstar97]

Thanks! Glad to have help an awesome library!
Even though it's the only one that didn't crash my app...
I tried the others... They didn't work for me
On May 9, 2016 2:16 PM, "mikemee" notifications@github.com wrote:

Thanks for that extra info. I've replicated this behaviour. Now I'm trying
to work out why it's broken. I expect to update here shortly... though
my laptop battery is running out...!

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5 (comment)

[mikemee]

In the meantime, I know you switched to using versionCode, but can you try the full semantic version again, i.e.: remove the minVersionCode from the json, replace it with minVersionName and try again with all the setPatchUpdateAlertType calls above? I know that worked for me in prior testing and that might get you going sooner than waiting for me to get a fix done. Thx!

[xstar97]

Your solution worked for me thanks...Your a life saver!

[mikemee]

Thanks. Glad it is working for you now, and thanks for reporting this and the prompt responses!

I think we still need to either more clearly document the current behaviour and/or fix the versionCode scenario as well as possibly add some tests, so I'll leave this open until we do.

[mikemee]

@Apisov, please take a look at this. thx!

[mikemee]

@xstar97 Did you try using siren.setVersionCodeUpdateAlertType(SirenAlertType.FORCE);

I sort of assumed that so I didn't ask, but now that we're testing, it seems that it works as expected. Maybe we just need to update the documentation to fix this!

[mikemee]

I've confirmed that this appears to work as requested:

    private void checkAvailableVersion() {
        Siren siren = Siren.getInstance(getApplicationContext());
        siren.setVersionCodeUpdateAlertType(SirenAlertType.FORCE);
        siren.checkVersion(this, SirenVersionCheckType.IMMEDIATELY, SIREN_JSON_DOCUMENT_URL);
    }