Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bind trigger for chanset #1393

Open
vanosg opened this issue Jan 29, 2023 · 3 comments · May be fixed by #1524
Open

Add bind trigger for chanset #1393

vanosg opened this issue Jan 29, 2023 · 3 comments · May be fixed by #1524
Milestone

Comments

@vanosg
Copy link
Member

vanosg commented Jan 29, 2023

Add a bind or bind event to cover changing a channel setting. Ie, .chanset #channel +foo activates a bind for the foo channel setting.

For discussion: add to bind EVNT, or a new bind? I don't think this fits under bind evnt as those are, so far, events that are external to Eggdrop. I don't know we need a bind dedicated to just this, but maybe there's an opportunity for a new EVENT-type bind, but focused towards internal eggdrop events? We've missed the boat on some things that could fall under this, like partyline signons/signoffs, but... whatever. Open to thoughts

@vanosg vanosg added this to the v1.10 milestone Jan 29, 2023
@vanosg
Copy link
Member Author

vanosg commented Feb 15, 2023

@thommey thoughts?

@vanosg
Copy link
Member Author

vanosg commented Apr 6, 2023

While we're at it, probably want to add a bind event for cap registrations/removals

@thommey
Copy link
Member

thommey commented Apr 8, 2023

Chanset binds would be useful, especially for custom int/string settings where you could apply validity checking and reject the change if it's not a valid value.
If this is only needed for custom (setudef) channel settings, we could allow to specify a proc in the setudef command itself to register such handler.
That would not work for core eggdrop settings though.
A bind would work for both, so those are the 2 options I could think of. One way or another, a return 1 or error thrown should reject the setting change as invalid, then this adds a lot of value and a often requested feature.

@vanosg vanosg linked a pull request Jan 13, 2024 that will close this issue
@vanosg vanosg modified the milestones: v1.10.0, v1.10.1 May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants