Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy-to-tmp 1 breaks sharing #490

Closed
thommey opened this issue Dec 2, 2017 · 0 comments
Closed

copy-to-tmp 1 breaks sharing #490

thommey opened this issue Dec 2, 2017 · 0 comments

Comments

@thommey
Copy link
Member

thommey commented Dec 2, 2017

with the new copy-to-tmp setting/code, it seems like copy-to-tmp being 1 breaks sharing under some circumstances (only observed with ssl so far).
there seems to be garbage memory before the actual userfile (45,000 bytes in one instance).
client stores the userfile but fails on loading it (no sanity check apparently), suggesting scripts/weed conversion and dies.

Found by: OUTsider (helped track down the issue)

@thommey thommey added this to the v1.8.3 milestone Dec 2, 2017
vanosg pushed a commit that referenced this issue Dec 6, 2017
…490

Found by: OUTsider, simple, Geo, ...
Patch by: Cizzle
Fixes: #490

The userfile being received is now properly being sent to a tmpfile first if copy-to-tmp is set.

* Use tmpfile for receiving userfile when copy-to-tmp is enabled.
* Alter docs regarding copy-to-tmp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant