Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset channel info on server disconnect #218

Merged
merged 1 commit into from Jul 9, 2016
Merged

Reset channel info on server disconnect #218

merged 1 commit into from Jul 9, 2016

Conversation

vanosg
Copy link
Member

@vanosg vanosg commented Jul 4, 2016

Found by: renols
Patch by: Geo
Fixes: #203

One-line summary:
Update channel info on server disconnect

Additional description (if needed):
Previous fix addressed channel parts/kicks, but missed separate code thread of dealing with server disconnects, such as when utilized via .jump. This exports reset_chan_info() to the server mod and calls when using from nuke_server().

Thanks to @rco133 for his continued persistence on this bug!

Test cases demonstrating functionality (if applicable):

.tcl botonchan #geo
Tcl: 1
.jump
[18:52:21] #Geo# jump
Jumping servers......
[18:52:21] Trying server [foo.com]:+7000
[18:52:21] Failed connect to foo.com (Operation now in progress)
.tcl botonchan #geo
Tcl: 0
....
....
[19:02:20] myBot joined #geo
.tcl botonchan #geo
Tcl: 1

@thommey thommey merged commit d4130c8 into develop Jul 9, 2016
@thommey thommey deleted the resetChanInfo branch July 9, 2016 15:16
thommey pushed a commit that referenced this pull request Oct 13, 2016
This fixes two instances missing in cc7240, in the fix for #218. Closes #275.
thommey pushed a commit to thommey/eggdrop that referenced this pull request Mar 23, 2017
This fixes two instances missing in cc7240, in the fix for eggheads#218. Closes eggheads#275.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

botonchan still not working.
2 participants