fix: convert unhandled rejection to uncaught exception (#235)

Mocha do not catch unhandled rejection by default. Case will faield until timeout. set `--unhandled-rejections` to strict, let case fail fast.
eggjs · Aug 7, 2023 · 489afd8 · 489afd8
1 parent c4301c5
commit 489afd8
Show file tree

Hide file tree

Showing 4 changed files with 25 additions and 1 deletion.
diff --git a/lib/cmd/test.js b/lib/cmd/test.js
@@ -90,7 +90,11 @@ class TestCommand extends Command {
       env: Object.assign({
         NODE_ENV: 'test',
       }, context.env),
-      execArgv: context.execArgv,
+      execArgv: [
+        ...context.execArgv,
+        // https://github.com/mochajs/mocha/issues/2640#issuecomment-1663388547
+        '--unhandled-rejections=strict',
+      ],
     };
     await this.helper.forkNode(mochaFile, testArgs, opt);
   }

diff --git a/test/fixtures/test-unhandled-rejection/package.json b/test/fixtures/test-unhandled-rejection/package.json
@@ -0,0 +1,6 @@
+{
+  "name": "test-unhandled-rejection",
+  "files": [
+    "lib"
+  ]
+}
diff --git a/test/fixtures/test-unhandled-rejection/test/a.test.js b/test/fixtures/test-unhandled-rejection/test/a.test.js
@@ -0,0 +1,7 @@
+'use strict';
+
+describe('a.test.js', () => {
+  it('should success', () => {
+    Promise.reject(new Error('mock error'));
+  });
+});
diff --git a/test/lib/cmd/test.test.js b/test/lib/cmd/test.test.js
@@ -291,6 +291,13 @@ describe('test/lib/cmd/test.test.js', () => {
       .expect('stdout', /env\.AUTO_AGENT: true/)
       .expect('stdout', /env\.ENABLE_MOCHA_PARALLEL: true/)
       .expect('code', 0)
+  });
+
+  it('should failed with unhandled rejection', () => {
+    return coffee.fork(eggBin, [ 'test' ], { cwd: path.join(__dirname, '../../fixtures/test-unhandled-rejection') })
+      .debug()
+      .expect('stdout', / Uncaught Error: mock error/)
+      .expect('code', 1)
       .end();
   });
 });