Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'test-local-changed' won't work properly on Windows #233

Closed
Wai-Dung opened this issue Jun 3, 2023 · 0 comments · Fixed by #234
Closed

'test-local-changed' won't work properly on Windows #233

Wai-Dung opened this issue Jun 3, 2023 · 0 comments · Fixed by #234

Comments

@Wai-Dung
Copy link
Contributor

Wai-Dung commented Jun 3, 2023 •
edited

Steps to Reproduce this issue:

If you change any test files (ending with 'test.js' in Egg project), and you run:

npm run test-local-changed

You'll always be told there's no file changed.

Reasons:

"globby" is referring "minimatch" for the global pattern searches.

In Windows, we can use either "/" or "\" as path seperators, however Only "/" is supported. Please read here: https://github.com/isaacs/minimatch#windows

Solutions:

To convert the "pattern" paths by replacing "" to "/".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Cannot detect file changes on Windows Wai-Dung/egg-bin
1 participant
@Wai-Dung