Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: use c8 instead of nyc when node >= 10.12.0 #134

Closed
wants to merge 4 commits into from
Closed

Conversation

popomore
Copy link
Member

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore
Copy link
Member Author

bcoe/c8#82

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #134 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #134   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         229    230    +1     
=====================================
+ Hits          229    230    +1
Impacted Files Coverage Δ
lib/cmd/cov.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 188c29c...05a6a84. Read the comment docs.

package.json Outdated
@@ -10,6 +10,7 @@
},
"dependencies": {
"autod": "^3.1.0",
"c8": "^3.5.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这玩意居然有 10M

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

太大。。。还不清楚它的优势。。。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就是不用自己做 instrument,v8 来做,可能会快点,等 ci 能过测下

@fengmk2 fengmk2 closed this Jun 3, 2022
@fengmk2 fengmk2 deleted the c8 branch June 3, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants