feat: support typescript #89

atian25 · 2018-03-24T02:45:15Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

Description of change

依赖于 fix: execArgv convert rule node-modules/common-bin#20
egg-bin dev 和 egg-bin debug
- 支持 --typescript 参数，会把 --require ts-node/register 加入到 execArgv
- 会传递给 startCluster typescript: true
- 支持 --require 参数，会加入到 execArgv 中
egg-bin test 和 egg-bin cov
- 支持 --typescript 参数，会把 --require ts-node/register 加入到 execArgv
- 会引入 espower-typescript 支持 ts 的 power-assert
- 加载 **/*.test.ts

codecov · 2018-03-24T03:14:18Z

Codecov Report

Merging #89 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff          @@
##           master    #89   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          11     11           
  Lines         167    183   +16     
=====================================
+ Hits          167    183   +16

Impacted Files	Coverage Δ
lib/command.js	`100% <100%> (ø)`	⬆️
lib/cmd/dev.js	`100% <100%> (ø)`	⬆️
lib/cmd/test.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48860c...6505b96. Read the comment docs.

atian25 · 2018-03-25T10:45:50Z

更新了下，依赖 node-modules/common-bin#20

whxaxes · 2018-03-26T03:04:52Z

README.md

@@ -80,6 +80,8 @@ $ egg-bin dev
 - `--port` server port, default to `7001`.
 - `--cluster` worker process number, skip this argvs will start only `1` worker, provide this without value will start `cpu` count worker.
 - `--sticky` start a sticky cluster server, default to `false`.
+- `--typescript` / `--ts` enable typescript support, default to `false`.
+- `--require` will add to `execArgv`, support multiple.


这些 flag 能否支持一下在 package.json 中配置，这样就不需要在每个 scripts 中都去加 --ts 了

其实还期望能否有 --require.once 这种 flag，就是能够在跑 egg 应用前跑一段 js，--require 是每起一个 child_process 也都会运行一次，如果我想在跑 egg 前，跑生成 d.ts 的程序（并且 watch 文件更改重新生成 d.ts），其实是不需要每个子进程都跑一次这个的，不然就起了一堆的 watcher 了

--require 是加到 execArgv 的，这个在 fork 里面就会默认继承的，所以肯定会跑一次。

package.json 那个可以做，下个 PR 看看

是啊，--require 是全部会继承的，就是说能否提供个能力，只运行一次的 require？比如在运行 egg 之前跑一次 tsc，或者跑一次 babel parse，这样就不需要在 scripts 中写 tsc && egg-bin dev 或者 tsc && egg-bin test 了，再加上支持配置在 package.json 中的话，那 scripts 中就只需要 egg-bin dev 及 egg-bin test 了

这个 PR 做完后，就不需要 tsc 了啊，不是有 ts-node 了么。

你这个需求感觉更类似于 npm scripts 本身的 beforeTest / beforeStart 的 hook

我知道，只是举个 tsc 的例子，对，就是类似于 beforeTest，但是 npm scripts 没有通用的 before，所以想 egg-bin 能否提供

这个不在这个 PR 的范畴内，等这个完后，考虑如何集成你的 ets 的时候再考虑。

tsc 要的，发布构建需要。

tsc 是构建发布那个流程的，这块是开发期辅助，不冲突。
构建那个不会存在他说的 require

atian25 · 2018-03-26T11:00:51Z

test/lib/cmd/cov.test.js

@@ -14,7 +14,14 @@ describe('test/lib/cmd/cov.test.js', () => {
  beforeEach(() => rimraf(path.join(cwd, 'coverage')));
  afterEach(mm.restore);

-  it('should success', done => {
+  function assertCoverage(cwd) {


哭，CI 上整体忽略掉这个，过 cov ci

有可能是 nyc 改了

popomore · 2018-03-24T03:32:08Z

lib/ts-helper.js

@@ -0,0 +1,28 @@
+'use strict';
+
+require('ts-node').register({


这些配置和 tsconfig 啥关系

这里提供默认值，应用层 tsconfig.json 可以覆盖

那最好只读 tsconfig.json，这个默认配置和 ts-node 的有差异？

这里的配置是针对 Node 应用的，ts-node 会考虑到前端应用，所以默认值不一样。

最新的已经去掉默认值了。开发者自己配置

popomore · 2018-03-26T11:36:25Z

egg-cluster 没改？

atian25 · 2018-03-26T11:41:20Z

egg-cluster 还没改，现在反正是透传的。那边也只是加一个文档就 ok 了。

popomore · 2018-03-26T11:42:05Z

没 egg-cluster 测的不真实吧

atian25 · 2018-03-26T11:44:40Z

这个可以加一个用例，之前是 egg-core 还没法版本。
我可以加一个用例先测，egg-cluster 那边可以同步发个 PR，那边只需要改下文档即可。

atian25 · 2018-03-26T12:00:33Z

eggjs/egg-cluster#61

atian25 · 2018-03-26T13:19:47Z

@popomore egg-cluster 那边加了用例了。这边不太好加，egg-bin 还没 drop 6.x support，用的是 egg@1 ，这个看这么搞？

Update:

学 egg-cluster 的 Travis ENV

atian25 · 2018-03-27T09:17:35Z

test/fixtures/example-ts/tsconfig.json

+    "strict": true,
+    "moduleResolution": "node",
+    "noImplicitAny": false,
+    "experimentalDecorators": true,


这里有没有一些可以精简掉

已经精简了，将跟默认值一样的值去掉了

atian25 · 2018-03-27T09:17:45Z

test/ts.test.js

@@ -17,7 +17,7 @@ describe('test/ts.test.js', () => {
      .debug()
      .expect('stdout', /### egg from ts/)
      .expect('stdout', /options.typescript=true/)
-      .expect('stdout', /egg started/)
+      .expect('stdout', /started/)


这个判断为啥干掉

在 Egg version 2 里，好像不会输出 egg stared 的内容，只会输出 application stared 等

所以单测一直跪在 egg@2 ，改成 stared 就正常了

sleep 的时间不够吧

whxaxes · 2018-03-27T09:20:46Z

ts-helper.js 不能干掉啊，默认的 register 是不带 typeCheck 的

atian25 · 2018-03-27T09:22:47Z

指的是干掉默认的 tsconfig

popomore · 2018-03-27T15:21:41Z

看起来没啥问题

atian25 · 2018-03-28T00:08:55Z

4.5.0

[skip ci] ## 1.0.0 (2022-12-17) ### Features * add `egg-bin autod --check` command ([#70](#70)) ([0f0c7ab](0f0c7ab)) * add COV_EXCLUDES for coverage excludes ([#7](#7)) ([a33e561](a33e561)) * add sticky mode support ([#32](#32)) ([f5a1152](f5a1152)) * add ts env in command ([#98](#98)) ([756310e](756310e)) * allow loading ts compiler from cwd ([#169](#169)) ([4a54cec](4a54cec)) * auto detect available port ([#22](#22)) ([6d7ad41](6d7ad41)) * auto require setup file ([#24](#24)) ([a847750](a847750)) * build-in intelli-espower-loader ([#20](#20)) ([4e86a67](4e86a67)) * change default timeout to 60000 ([#50](#50)) ([cbc9263](cbc9263)) * commands support specific execArgv(harmony) ([#33](#33)) ([0c7108b](0c7108b)) * cov support output json-summary ([#64](#64)) ([c1de734](c1de734)) * cov support typescript ([#91](#91)) ([8a05e19](8a05e19)) * **cov:** add nyc instrument passthrough ([#103](#103)) ([8fa805b](8fa805b)) * **cov:** add prerequire option ([#53](#53)) ([055c47f](055c47f)) * **cov:** add prerequire option ([#53](#53)) ([a6a2b4a](a6a2b4a)) * debug proxy support ([678b83d](678b83d)) * **debug:** [BREAKING_CHANGE] remove iron-node ([#26](#26)) ([9d4170f](9d4170f)) * default enable c8 report ([#189](#189)) ([72e925b](72e925b)) * **dev:** pass debug args to execArgv ([#12](#12)) ([92b111f](92b111f)) * egg-bin check ([#87](#87)) ([92b1489](92b1489)) * enable mochawesome by default ([#193](#193)) ([6636e8f](6636e8f)) * expose proc ([#152](#152)) ([dcc9b25](dcc9b25)) * extractArgv refactor & extract debug port ([994616d](994616d)) * extractArgv support expose_debug_as ([6f5d525](6f5d525)) * impl parallel for mocha parallel mode ([#185](#185)) ([78141e8](78141e8)) * intergration with egg-ts-helper ([#123](#123)) ([263cfd1](263cfd1)) * pass --check to pkgfiles ([#48](#48)) ([7b0c995](7b0c995)) * remove correct-source-map.js ([#109](#109)) ([8b62742](8b62742)) * resolve istanbul path for coffee ([#9](#9)) ([147add8](147add8)) * revert egg-bin check ([#90](#90)) ([83322e6](83322e6)) * revert to 4.2.0 ([c65a00d](c65a00d)) * set EGG_MASTER_CLOSE_TIMEOUT when run dev ([#88](#88)) ([c48860c](c48860c)) * should print error stack ([#132](#132)) ([5c621f6](5c621f6)) * simplify mocha error stack ([#59](#59)) ([0b01158](0b01158)) * support $NODE_DEBUG_OPTION ([#71](#71)) ([1340ce7](1340ce7)) * support c8 report ([#172](#172)) ([1e96da2](1e96da2)) * support cov command in win32 ([#52](#52)) ([93b731d](93b731d)) * support egg-bin test --changed ([#111](#111)) ([51f93aa](51f93aa)) * support egg.typescript ([#92](#92)) ([a7f0ca8](a7f0ca8)) * support mocha custom require args ([#5](#5)) ([fb8fd32](fb8fd32)) * support read egg.require from package.json ([#121](#121)) ([904103f](904103f)) * support set eggTsHelper ([#183](#183)) ([f564cbf](f564cbf)) * support switch ts compiler ([#158](#158)) ([a74bae2](a74bae2)) * support typescript ([#89](#89)) ([75b5cd6](75b5cd6)) * test --dry-run ([#145](#145)) ([3cc3b0b](3cc3b0b)) * try to use --inspect first ([#19](#19)) ([d7ad24c](d7ad24c)) * update pkg.files that if file exists ([#37](#37)) ([af5af6a](af5af6a)) * upgrade espower-typescript to 9.0 ([#106](#106)) ([35e89db](35e89db)) * use nyc instead of istanbul ([#63](#63)) ([3cf312c](3cf312c)) * use test when run cov on Windows ([#18](#18)) ([611027f](611027f)), closes [/github.com/eggjs/egg/pull/133#issuecomment-256827488](https://github.com/eggjs//github.com/eggjs/egg/pull/133/issues/issuecomment-256827488) * use unparseArgv from common-bin ([#45](#45)) ([da41b8e](da41b8e)) ### Bug Fixes * --full-trace should be boolean ([#191](#191)) ([bfd7fab](bfd7fab)) * -x only support string ([#47](#47)) ([b79f0cc](b79f0cc)) * .setup.js should be the first test file ([#30](#30)) ([4f45c6b](4f45c6b)) * add missing deps ([#42](#42)) ([86ebc75](86ebc75)) * add power-assert to deps ([#21](#21)) ([8b7ce8d](8b7ce8d)) * auto add .setup.ts file ([#147](#147)) ([00afdf7](00afdf7)) * can not find iron-node in subprocess ([#8](#8)) ([d6a57f5](d6a57f5)) * ci failed ([#162](#162)) ([4a076e6](4a076e6)) * clean more mocha error stack ([#60](#60)) ([9c77118](9c77118)) * conflix source map support ([#181](#181)) ([a1ec4f7](a1ec4f7)) * cov replaced warning at win ([#49](#49)) ([d2850a5](d2850a5)) * **cov:** istanbul path env ([#44](#44)) ([ce8f141](ce8f141)) * **cov:** wait 1 second for Windows ([#16](#16)) ([742f6fc](742f6fc)) * debug at 6.x ([469739f](469739f)) * debug mode detect ([#130](#130)) ([819d78f](819d78f)) * debug-test invoke formatTestArgs ([a82a87a](a82a87a)) * don't pass prerequire ([#57](#57)) ([e0d03d3](e0d03d3)) * downgrade ts-node ([#126](#126)) ([d802694](d802694)) * egginfo is not exists ([#159](#159)) ([8666e9e](8666e9e)) * ets not found ([#124](#124)) ([8f6135e](8f6135e)) * fix cov env ([#188](#188)) ([e18ceda](e18ceda)) * fix ENABLE_MOCHA_PARALLEL/AUTO_AGENT env ([#187](#187)) ([88ba6d5](88ba6d5)) * fix espwoer-typescript inject logic ([#178](#178)) ([2e0fecd](2e0fecd)) * fix source map line number incorrect ([#107](#107)) ([ca4f78f](ca4f78f)), closes [/github.com/TypeStrong/ts-node/blob/master/src/index.ts#L218](https://github.com/eggjs//github.com/TypeStrong/ts-node/blob/master/src/index.ts/issues/L218) * fixed ts-node ignore files ([#105](#105)) ([a790304](a790304)) * force exit when runner complete ([#83](#83)) ([7386194](7386194)) * ignore eggTsHelper on node-test ([#186](#186)) ([c5db00e](c5db00e)) * ignore frontend files and document files ([#65](#65)) ([f9d578e](f9d578e)) * let sub class can override getFrameworkOrEggPath ([1320144](1320144)) * link mocha bin from inner file ([#15](#15)) ([f6cb195](f6cb195)) * make sure dev command eggPath can be override ([#23](#23)) ([22510d7](22510d7)) * make sure files sort in all platforms ([#86](#86)) ([6689962](6689962)) * nyc shim ([#138](#138)) ([3b370ef](3b370ef)) * only hotfix spawn-wrap on windows ([#69](#69)) ([e784a3d](e784a3d)) * package.json to reduce vulnerabilities ([#108](#108)) ([e910ae3](e910ae3)) * package.json to reduce vulnerabilities ([#81](#81)) ([e3c33e9](e3c33e9)) * remove espower typescript ([#160](#160)) ([563923a](563923a)) * remove temp excludes ([40aaca1](40aaca1)) * remove ts extensions by default ([#94](#94)) ([1c860a9](1c860a9)) * revert nyc ([#140](#140)) ([9cb8125](9cb8125)), closes [/github.com//pull/133#issuecomment-489387659](https://github.com/eggjs//github.com/eggjs/egg-bin/pull/133/issues/issuecomment-489387659) * should exit when no test files found ([#100](#100)) ([e375ba4](e375ba4)) * should ignore fixtures and node_modules ([#96](#96)) ([e73c569](e73c569)) * should not timeout when debugging ([#129](#129)) ([3b6819c](3b6819c)) * should only read pkg if argv.typescript not pass ([#97](#97)) ([1e93020](1e93020)) * should pass customEgg to startCluster ([#25](#25)) ([e3d7974](e3d7974)) * should support -p ([#27](#27)) ([df86893](df86893)) * should support multi exclude dirs ([#66](#66)) ([1ac9d68](1ac9d68)) * support --workers same as egg-scripts ([#127](#127)) ([fcae123](fcae123)) * support egg-bin dev --cluster and --baseDir ([#36](#36)) ([ba7d409](ba7d409)) * support node4 ([#35](#35)) ([dbbaf98](dbbaf98)) * support relative path ([#95](#95)) ([7531faa](7531faa)) * There is a case sensitive issue from spawn-wrap on Windows ([#67](#67)) ([56f8518](56f8518)) * use co-mocha instead of thunk-mocha ([#38](#38)) ([f6b5171](f6b5171)) * use context.env instead of process.env ([#58](#58)) ([9aa0030](9aa0030)) * use inspector at 7.x+ ([#74](#74)) ([2e3498e](2e3498e)) * using ts-node in app should check tscompiler and deps ([#170](#170)) ([662b9e9](662b9e9)) * wait more time for Window 😢 ([#17](#17)) ([d6f6b3b](d6f6b3b))

atian25 changed the title ~~Ts node~~ feat: support typescript Mar 24, 2018

atian25 force-pushed the ts-node branch from 4857356 to 77f2a91 Compare March 24, 2018 03:14

atian25 force-pushed the ts-node branch 3 times, most recently from 713b0fb to 266abdd Compare March 25, 2018 10:42

atian25 requested review from popomore and dead-horse March 25, 2018 10:45

whxaxes reviewed Mar 26, 2018

View reviewed changes

atian25 force-pushed the ts-node branch 2 times, most recently from 8881fad to dd0a889 Compare March 26, 2018 05:46

feat: add typescript support

dd4302e

atian25 force-pushed the ts-node branch from dd0a889 to dd4302e Compare March 26, 2018 09:27

test: fix cov

ed4453d

atian25 force-pushed the ts-node branch from 87e9290 to ed4453d Compare March 26, 2018 10:52

atian25 commented Mar 26, 2018

View reviewed changes

popomore reviewed Mar 26, 2018

View reviewed changes

fix: espower-typescript fullpath

975ba18

atian25 mentioned this pull request Mar 26, 2018

[RFC] TypeScript tool support eggjs/egg#2272

Closed

28 tasks

test: add egg2 test && real cluster test

e5a37cb

atian25 force-pushed the ts-node branch from 21a504b to 9669f63 Compare March 26, 2018 14:18

test: remove appveyor egg@1 nodee@6

645a364

atian25 force-pushed the ts-node branch from 9669f63 to 645a364 Compare March 27, 2018 00:00

f

4222b74

atian25 mentioned this pull request Mar 27, 2018

feat: set EGG_MASTER_CLOSE_TIMEOUT when run dev #88

Merged

4 tasks

atian25 added 5 commits March 27, 2018 12:45

feat: add typescript support

a670ca6

test: fix cov

4606640

fix: espower-typescript fullpath

ed00eb0

test: add egg2 test && real cluster test

ef2b479

test: remove appveyor egg@1 nodee@6

8f46c16

atian25 force-pushed the ts-node branch from 645a364 to 8f46c16 Compare March 27, 2018 04:46

whxaxes and others added 6 commits March 27, 2018 15:08

feat: remove index.test.js

9de39aa

feat: add tsconfig.json

d4475ac

fix: fixed test app

2f806f3

test: updated ts test

d2cd77e

feat: set EGG_MASTER_CLOSE_TIMEOUT when run dev (#88)

1c88d0c

Merge branch 'ts-node' of https://github.com/eggjs/egg-bin into ts-node

711264e

atian25 commented Mar 27, 2018

View reviewed changes

whxaxes added 3 commits March 27, 2018 18:03

chore: optimizated tsconfig

4d9d882

chore: remove charset in tsconfig

fff57c3

chore: change noImplicitAny to false

6505b96

popomore approved these changes Mar 27, 2018

View reviewed changes

atian25 merged commit 75b5cd6 into master Mar 28, 2018

atian25 deleted the ts-node branch March 28, 2018 00:04

feat: support typescript #89

feat: support typescript #89

Conversation

atian25 commented Mar 24, 2018 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

codecov bot commented Mar 24, 2018 • edited Loading

Codecov Report

atian25 commented Mar 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atian25 Mar 27, 2018 • edited Loading

Choose a reason for hiding this comment

popomore commented Mar 26, 2018

atian25 commented Mar 26, 2018

popomore commented Mar 26, 2018

atian25 commented Mar 26, 2018

atian25 commented Mar 26, 2018

atian25 commented Mar 26, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

whxaxes commented Mar 27, 2018

atian25 commented Mar 27, 2018

popomore commented Mar 27, 2018

atian25 commented Mar 28, 2018

atian25 commented Mar 24, 2018 •

edited

Loading

codecov bot commented Mar 24, 2018 •

edited

Loading

atian25 Mar 27, 2018 •

edited

Loading

atian25 commented Mar 26, 2018 •

edited

Loading