Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop 4.x support #9

Closed
wants to merge 1 commit into from
Closed

feat: drop 4.x support #9

wants to merge 1 commit into from

Conversation

atian25
Copy link
Member

@atian25 atian25 commented Mar 25, 2017

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@atian25 atian25 requested a review from popomore March 25, 2017 08:25
@mention-bot
Copy link

@atian25, thanks for your PR! By analyzing the history of the files in this pull request, we identified @popomore to be a potential reviewer.

@atian25 atian25 changed the title feat: only support 6.x+ feat: drop 4.x support Mar 25, 2017
@popomore
Copy link
Member

模块基本还是4吧

@atian25
Copy link
Member Author

atian25 commented Mar 25, 2017

@popomore 可是 egg-bin 不支持 4 了

@popomore
Copy link
Member

popomore commented Mar 25, 2017 via email

@dead-horse
Copy link
Member

@popomore 你说的模块指的是什么?这个不是用来初始化 egg 项目的么

@popomore
Copy link
Member

popomore commented Mar 26, 2017 via email

@atian25
Copy link
Member Author

atian25 commented Mar 26, 2017 via email

@dead-horse
Copy link
Member

那这个用来干嘛的?

@atian25
Copy link
Member Author

atian25 commented Mar 26, 2017 via email

@dead-horse
Copy link
Member

好吧,这个有点奇怪,common-bin 这种按理说不应该与 egg 有关,用 egg 的脚手架来初始化

@atian25
Copy link
Member Author

atian25 commented Mar 26, 2017 via email

@popomore
Copy link
Member

popomore commented Apr 1, 2017

这个关了好了

@atian25 atian25 closed this Apr 1, 2017
@atian25 atian25 deleted the 6.x branch April 1, 2017 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants