New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop 4.x support #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
模块基本还是4吧 |
@popomore 可是 egg-bin 不支持 4 了 |
用 egg-bin 1 好了
TZ | 天猪 <notifications@github.com>于2017年3月25日 周六18:20写道:
… @popomore <https://github.com/popomore> 可是 egg-bin 不支持 4 了
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWA1XwNfZDCo7yjOI1z5h_Yu_n2IbhEks5rpOpwgaJpZM4MpAfc>
.
|
dead-horse
approved these changes
Mar 26, 2017
@popomore 你说的模块指的是什么?这个不是用来初始化 egg 项目的么 |
Egg 是 simple
Yiyu He <notifications@github.com>于2017年3月26日 周日13:15写道:
… @popomore <https://github.com/popomore> 你说的模块指的是什么?这个不是用来初始化 egg 项目的么
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWA1U4Ck2mbD6X3usfokXGaKPmV1nkWks5rpfRrgaJpZM4MpAfc>
.
|
这个先 hold 吧,到时重构 egg-init 的时候加一个 prompt 自动配置
发自我的 iPhone
… 在 2017年3月26日,13:18,Haoliang Gao ***@***.***> 写道:
Egg 是 simple
Yiyu He ***@***.***>于2017年3月26日 周日13:15写道:
> @popomore <https://github.com/popomore> 你说的模块指的是什么?这个不是用来初始化 egg 项目的么
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#9 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAWA1U4Ck2mbD6X3usfokXGaKPmV1nkWks5rpfRrgaJpZM4MpAfc>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
那这个用来干嘛的? |
普通的类库,如 egg-bin, common-bin 之类
发自我的 iPhone
… 在 2017年3月26日,13:32,Yiyu He ***@***.***> 写道:
那这个用来干嘛的?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
好吧,这个有点奇怪,common-bin 这种按理说不应该与 egg 有关,用 egg 的脚手架来初始化 |
还好,只是 egg-init 的职责扩大了,类似我们自己用的一个初始化工具,更像 common-init 。然后 empty 这个骨架只有 eslint, npm scripts 等东西,没有 egg 的内容。
发自我的 iPhone
… 在 2017年3月26日,13:39,Yiyu He ***@***.***> 写道:
好吧,这个有点奇怪,common-bin 这种按理说不应该与 egg 有关,用 egg 的脚手架来初始化
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
这个关了好了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesAffected core subsystem(s)
Description of change