fix: sleep 100ms to make sure SIGTERM send to the child processes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dead-horse, @popomore and @atian25 to be potential reviewers. |
|
这个用例之前就是挂的，得看看 |
|
port 被设置为默认 7001了，为看看哪里设置的 Line 69 in d0619e0 |
|
https://github.com/eggjs/egg/pull/1231/files#diff-00e468d07603246fbc402f6599122162R299 这里加了一个 port，为再改改单测代码。 |
fengmk2
force-pushed
the
sleep-100ms-before-exit
branch
from
c9ad1ae
to
24a0d8d
Compare
|
rebase 好了，等 ci |
|
@popomore 可以合并发布了。 |
popomore
approved these changes
Aug 28, 2017
|
hyj1991
pushed a commit
to hyj1991/egg-cluster
that referenced
this pull request
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change