feat: app.js/agent.js support async function #18

popomore · 2016-10-17T09:44:54Z

Checklist

npm test passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

custom app/agent

Description of change

You can use async function to write async code, never readyCallback.

module.exports = async function(app) {
  await doAsync();
};

Or use promise wrap on old node

const co = require('co');
module.exports = co.wrap(function* (app) {
  yield doAsync();
});

Closes eggjs/egg#51

fengmk2 · 2016-10-17T12:51:45Z

lib/egg.js

@@ -157,6 +158,8 @@ class EggCore extends KoaApplication {
    }).on('ready_timeout', id => {
      this.console.warn('[egg:core:ready_timeout] 10 seconds later %s was still unable to finish.', id);
    });
+
+    this.ready(() => debug('egg emit ready, application started'));


改成 this.logger.debug 吧

debug 调试起来方便吧

但是对项目开发者不方便。logger.debug 也可以通过环境变量打开。

我们把 logger.debug 换成 node 的 debug？现在 debug 不能用环境变量打开，没有作用域，而且不能应用于底层模块。还有不能单独开启 debug，开启后 info 以上都会开启。

codecov-io · 2016-10-19T04:51:34Z

Current coverage is 99.84% (diff: 100%)

Merging #18 into master will increase coverage by <.01%

@@             master        #18   diff @@
==========================================
  Files            16         16          
  Lines           622        631     +9   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            621        630     +9   
  Misses            1          1          
  Partials          0          0

Powered by Codecov. Last update 023007c...5d83d04

popomore · 2016-10-19T05:25:29Z

Closes eggjs/egg#51

atian25 · 2016-10-19T05:50:41Z

test/fixtures/custom-app-error/app.js

@@ -0,0 +1,10 @@
+'use strict';
+
+// TODO can use co


TODO 干掉?

atian25 · 2016-10-19T05:51:06Z

test/fixtures/custom-app-promise/app.js

@@ -0,0 +1,11 @@
+'use strict';
+
+// TODO can use co


我改下，在飞机上没网络

atian25 · 2016-10-19T05:51:41Z

test/loader/mixin/load_custom_app.test.js

-    app.app.should.equal('app');
+  describe('app.js as function return promise', function() {
+    let app;
+    before(function(done) {


() => return app.ready()

popomore · 2016-10-19T06:30:06Z

改成 co 了

atian25 · 2016-10-19T07:06:37Z

test/loader/mixin/load_custom_app.test.js

-    (app.dateC <= app.date).should.equal(true);
+  describe('app.js as async function', () => {
+    let app;
+    before(done => {


before(() => { ... return app.done(); });

这个没关系吧，都一样

atian25 · 2016-10-19T07:08:09Z

lib/loader/mixin/custom.js

@@ -18,19 +20,41 @@ module.exports = {
   *   doAsync(done);
   * }
   * ```
+   *
+   * it's better to use async function or generator wrapped by co.wrap


co 的也加上示例吧, 毕竟 node 7 LTS 还很遥远

好的，我加下

fengmk2 · 2016-10-19T16:41:13Z

+1

fengmk2 · 2016-10-19T16:43:24Z

test/fixtures/custom-app-promise/app.js

+
+module.exports = co.wrap(function*(app) {
+  yield wait(1000);
+  console.log(app);


这个删除了吧

fengmk2 · 2016-10-19T16:47:24Z

console 删除了吧 @popomore

You can use async function to write async code, never readyCallback. ```js module.exports = async function(app) { await doAsync(); }; ``` Or use promise wrap on old node ```js const co = require('co'); module.exports = co.wrap(function* (app) { yield doAsync(); }); ```

popomore · 2016-10-20T04:17:53Z

删掉了

popomore · 2016-10-24T08:51:54Z

这个差不多可以合了

popomore · 2016-10-24T10:17:36Z

Windows 先别关，修好了一起改。

popomore · 2016-10-24T10:18:54Z

@dead-horse 这个有问题么

dead-horse · 2016-10-24T10:41:43Z

windows 的测试不用管么？� async function 的没有问题啊，不过还是想把 generator function 的默认支持加上。。

popomore · 2016-10-24T11:54:03Z

合了吧，网络问题 cnpm/npminstall#152

popomore · 2016-10-24T11:54:19Z

合完我发个版本

popomore · 2016-10-24T12:03:23Z

@fengmk2 appvoyer 你能 retry？

popomore · 2016-10-24T12:11:25Z

egg-core@0.5.0

```bash egg start timeline: ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start ▇ [2ms] - #2 Load Plugin ▇ [1ms] - #3 Load Config ▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js ▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js ▇ [0ms] - #6 Load extend/application.js ▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js ▇ [1ms] - #8 Load extend/context.js ▇ [0ms] - #9 Load extend/request.js ▇ [0ms] - #10 Load extend/response.js ▇ [1ms] - #11 Load app.js ▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js ▇ [0ms] - #13 Require(4) app.js ▇▇▇▇▇▇ [101ms] - #14 readyCallback in a ▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b ▇ [4ms] - #16 Load Middleware ▇ [4ms] - #17 Load "middlewares" to Application ▇ [2ms] - #18 Load Service ▇ [2ms] - #19 Load "service" to Context ▇ [0ms] - #20 Load Controller ▇ [0ms] - #21 Load "controller" to Application ▇ [0ms] - #22 Load Router ```

[skip ci] ## [5.3.0](v5.2.0...v5.3.0) (2023-01-13) ### Features * support show app.timing in timline string ([#260](#260)) ([5b7af12](5b7af12)), closes [#0](https://github.com/eggjs/egg-core/issues/0) [#1](#1) [#2](#2) [#3](#3) [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#9](#9) [#10](#10) [#11](#11) [#12](#12) [#13](#13) [#14](#14) [#15](#15) [#16](#16) [#17](#17) [#18](#18) [#19](#19) [#20](#20) [#21](#21) [#22](#22)

fengmk2 reviewed Oct 17, 2016

View reviewed changes

popomore force-pushed the app-promise branch from 3f4767c to 86b178d Compare October 19, 2016 03:18

atian25 reviewed Oct 19, 2016

View reviewed changes

test/fixtures/custom-app-error/app.js

@@ -0,0 +1,10 @@

'use strict';

// TODO can use co

Copy link

Member

atian25 Oct 19, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO 干掉?

atian25 reviewed Oct 19, 2016

View reviewed changes

popomore force-pushed the app-promise branch from 5fd9fae to 3b5fe2d Compare October 19, 2016 06:28

atian25 reviewed Oct 19, 2016

View reviewed changes

popomore force-pushed the app-promise branch from 3b5fe2d to c8dd858 Compare October 19, 2016 07:35

fengmk2 reviewed Oct 19, 2016

View reviewed changes

popomore force-pushed the app-promise branch from c8dd858 to 016de84 Compare October 20, 2016 04:02

Merge branch 'master' into app-promise

5d83d04

popomore assigned fengmk2 Oct 24, 2016

Merge branch 'master' into app-promise

ecf662b

popomore merged commit 72e8b00 into master Oct 24, 2016

popomore deleted the app-promise branch October 24, 2016 12:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: app.js/agent.js support async function #18

feat: app.js/agent.js support async function #18

popomore commented Oct 17, 2016 •

edited

fengmk2 Oct 17, 2016

popomore Oct 19, 2016

fengmk2 Oct 19, 2016

popomore Oct 19, 2016

codecov-io commented Oct 19, 2016 •

edited

popomore commented Oct 19, 2016

atian25 Oct 19, 2016

atian25 Oct 19, 2016

popomore Oct 19, 2016

atian25 Oct 19, 2016

popomore commented Oct 19, 2016

atian25 Oct 19, 2016

popomore Oct 19, 2016

atian25 Oct 19, 2016

popomore Oct 19, 2016

fengmk2 commented Oct 19, 2016

fengmk2 Oct 19, 2016

fengmk2 commented Oct 19, 2016

popomore commented Oct 20, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

dead-horse commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

feat: app.js/agent.js support async function #18

feat: app.js/agent.js support async function #18

Conversation

popomore commented Oct 17, 2016 • edited

Checklist

Affected core subsystem(s)

Description of change

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 19, 2016 • edited

Current coverage is 99.84% (diff: 100%)

popomore commented Oct 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

popomore commented Oct 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fengmk2 commented Oct 19, 2016

Choose a reason for hiding this comment

fengmk2 commented Oct 19, 2016

popomore commented Oct 20, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

dead-horse commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 24, 2016

popomore commented Oct 17, 2016 •

edited

codecov-io commented Oct 19, 2016 •

edited