feat: support plugin.{env}.js #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@popomore, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gxcsoccer to be a potential reviewer. |
|
plugin 也要支持 env？ |
fengmk2
reviewed
Oct 17, 2016
| // note: can't use for-of | ||
| for (let i = 0, l = configPaths.length; i < l; i++) { | ||
| const configPath = configPaths[i]; | ||
| configPaths.push(configPath.replace(/plugin.js$/, `plugin.${this.serverEnv}.js`)); |
There was a problem hiding this comment.
/plugin.js$/ => /\/plugin.js$/ 少了一个 /
|
这样不用 concat 了 |
|
@atian25 这样可以根据环境变量控制插件集合 |
|
那是不是之前那个 |
|
config 是没有 config.js 的，那 plugin.js 也要改为 plugin.default.js 么？ 后面这句当我没说 |
Control bundle of plugins by env easily
popomore
force-pushed
the
load-plugin-by-env
branch
from
160a9f2
to
28f0597
Compare
|
这里的 env 大部分是自定义的，感觉不需要类似 config 那样的。这个和 eggPlugin.env 有点冲突，感觉由应用来控制更合理，插件本身控制用在哪种环境感觉太分散了。 |
Current coverage is 99.83% (diff: 100%)@@ master #20 diff @@
==========================================
Files 16 16
Lines 619 615 -4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 618 614 -4
Misses 1 1
Partials 0 0
|
|
serverEnv 不是只有我们预设的值么? 还可以为其他的? |
|
对，希望支持自定义的。 |
|
如果支持自定义，那么插件配置 env 就会很奇怪了。 |
|
那光改这里还不够吧, 如果自定义的话, 有可能还需要 egg-cluster 里面的 isProduction 的判断. 我上面那个疑问的意思是: 如果当前是 prod, 而某个插件是在 plugin.local.js 中定义的, 那它是否还会被 require? |
|
肯定不会啊 |
|
那就变相实现之前的那个需求了. 另外:
|
|
plugin.js 中的 env 也是向下兼容的，如果有 plugin.env.js 感觉这种写法根本没必要了。问题回到“谁来控制插件开关”。 |
|
现在生产环境可能存在同一套代码多套部署的情况，如果支持这种方式，那么可以定义多个环境变量，每个环境变量定义差异的插件集合，部署时通过环境来切换。 |
|
+1 |
|
merge from master, wait for ci pass. |
fengmk2
added a commit
that referenced
this pull request
Jan 13, 2023
```bash
egg start timeline:
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start
▇ [2ms] - #2 Load Plugin
▇ [1ms] - #3 Load Config
▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js
▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js
▇ [0ms] - #6 Load extend/application.js
▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js
▇ [1ms] - #8 Load extend/context.js
▇ [0ms] - #9 Load extend/request.js
▇ [0ms] - #10 Load extend/response.js
▇ [1ms] - #11 Load app.js
▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js
▇ [0ms] - #13 Require(4) app.js
▇▇▇▇▇▇ [101ms] - #14 readyCallback in a
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b
▇ [4ms] - #16 Load Middleware
▇ [4ms] - #17 Load "middlewares" to Application
▇ [2ms] - #18 Load Service
▇ [2ms] - #19 Load "service" to Context
▇ [0ms] - #20 Load Controller
▇ [0ms] - #21 Load "controller" to Application
▇ [0ms] - #22 Load Router
```
fengmk2
added a commit
that referenced
this pull request
Jan 13, 2023
```bash
egg start timeline:
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [289ms] - #0 Process Start
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [510ms] - #1 Application Start
▇ [2ms] - #2 Load Plugin
▇ [1ms] - #3 Load Config
▇ [0ms] - #4 Require(0) ~/eggjs/egg-core/test/fixtures/egg/config/config.default.js
▇ [0ms] - #5 Require(1) ~/eggjs/egg-core/test/fixtures/egg/config/config.unittest.js
▇ [0ms] - #6 Load extend/application.js
▇ [0ms] - #7 Require(2) ~/eggjs/egg-core/test/fixtures/egg/app/extend/application.js
▇ [1ms] - #8 Load extend/context.js
▇ [0ms] - #9 Load extend/request.js
▇ [0ms] - #10 Load extend/response.js
▇ [1ms] - #11 Load app.js
▇ [0ms] - #12 Require(3) ~/eggjs/egg-core/test/fixtures/egg/node_modules/session/app.js
▇ [0ms] - #13 Require(4) app.js
▇▇▇▇▇▇ [101ms] - #14 readyCallback in a
▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇▇ [501ms] - #15 readyCallback in b
▇ [4ms] - #16 Load Middleware
▇ [4ms] - #17 Load "middlewares" to Application
▇ [2ms] - #18 Load Service
▇ [2ms] - #19 Load "service" to Context
▇ [0ms] - #20 Load Controller
▇ [0ms] - #21 Load "controller" to Application
▇ [0ms] - #22 Load Router
```
atian25
pushed a commit
that referenced
this pull request
Jan 13, 2023
[skip ci] ## [5.3.0](v5.2.0...v5.3.0) (2023-01-13) ### Features * support show app.timing in timline string ([#260](#260)) ([5b7af12](5b7af12)), closes [#0](https://github.com/eggjs/egg-core/issues/0) [#1](#1) [#2](#2) [#3](#3) [#4](#4) [#5](#5) [#6](#6) [#7](#7) [#8](#8) [#9](#9) [#10](#10) [#11](#11) [#12](#12) [#13](#13) [#14](#14) [#15](#15) [#16](#16) [#17](#17) [#18](#18) [#19](#19) [#20](#20) [#21](#21) [#22](#22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
load plugin
Description of change
Control bundle of plugins by env easily