Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Loader can be instantiated without timing #161

Merged
merged 1 commit into from
May 8, 2018
Merged

fix: Loader can be instantiated without timing #161

merged 1 commit into from
May 8, 2018

Conversation

popomore
Copy link
Member

@popomore popomore commented May 7, 2018

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@popomore popomore requested a review from gxcsoccer May 7, 2018 14:36
@codecov
Copy link

codecov bot commented May 7, 2018 •
edited
Loading

Codecov Report

Merging #161 into 3.x will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            3.x   #161   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        18     18           
  Lines       947    948    +1     
===================================
+ Hits        947    948    +1
Impacted Files Coverage Δ
lib/loader/egg_loader.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72702d8...2459acb. Read the comment docs.

@gxcsoccer
Copy link
Contributor

ci 挂了

@popomore
Copy link
Member Author

popomore commented May 7, 2018

明天再发

@popomore popomore merged commit f58a142 into 3.x May 8, 2018
@popomore popomore deleted the fix-timing-noexist branch May 8, 2018 04:04
@popomore
Copy link
Member Author

popomore commented May 8, 2018

  • egg-core@3.21.1

popomore added a commit that referenced this pull request May 22, 2018
@popomore
fix: Loader can be instantiated without timing (#161)
55cf370
@popomore popomore mentioned this pull request May 22, 2018
Merged
4 tasks
popomore added a commit that referenced this pull request May 22, 2018
@popomore
feat: pick commit from 3.x (#166)
bb24396 
* feat: add timing data for loader (#160)
* refactor: add timing to extend (#162)
* fix: Loader can be instantiated without timing (#161)
* fix: convert symbol to string (#163)
* fix: timing can be started multiple times (#164)
hyj1991 pushed a commit to hyj1991/egg-core that referenced this pull request Sep 16, 2021
@popomore
feat: pick commit from 3.x (eggjs#166)
4a9037d 
* feat: add timing data for loader (eggjs#160)
* refactor: add timing to extend (eggjs#162)
* fix: Loader can be instantiated without timing (eggjs#161)
* fix: convert symbol to string (eggjs#163)
* fix: timing can be started multiple times (eggjs#164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atian25 atian25 atian25 approved these changes

@gxcsoccer gxcsoccer Awaiting requested review from gxcsoccer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@popomore @gxcsoccer @atian25