fix(plugin loader): load plugin in npm flattened dependencies tree #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesAffected core subsystem(s)
Description of change
try to find plugin in
EGG_PATH/node_modules
andEGG_PATH/../
.The problem I got
can't load buildin plugin like
egg-onerror
in test case ofegg-script
:couldn't pass test case: test/egg-scripts.test.js -> start without daemon -> without baseDir, error:
the plugin loader try to load
egg-onerror
plugin, in three path:but
egg-onerror
was installed into/Users/fake/code/egg-scripts/node_modules
actuallyNote:
npminstall
(cnpm
) works fine, would pass every test cases inegg-scripts
.egg-scripts
.