feat: can disable fast ready #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jtyjty99999 and @atian25 to be potential reviewers. |
atian25
reviewed
Jan 3, 2017
| exports.development = { | ||
| watchDirs: [], // dirs needed watch, when files under these change, application will reload. | ||
| ignoreDirs: [], // dirs don't need watch, including subdirectories | ||
| fastReady: true, |
atian25
reviewed
Jan 3, 2017
| @@ -4,8 +4,10 @@ | |||
| * @member Config#development | |||
| * @property {Array} watchDirs - dirs needed watch, when files under these change, application will reload, use relative path | |||
| * @property {Array} ignoreDirs - dirs don't need watch, including subdirectories, use relative path | |||
| * @property {Boolean} fastReady - don't wait all plugins ready, default is true. | |||
There was a problem hiding this comment.
那要在 readme 里面说明下默认开启且可能导致的错误场景? 内网版不是有人踩坑了么
There was a problem hiding this comment.
不加了，加了反而更加麻烦。内网也就一个人觉得会有问题。如果需要 fastready = false，直接关闭这个插件更好。。。
fengmk2
force-pushed
the
add-faster-ready
branch
from
1ff9cdd
to
c4c543e
Compare
Current coverage is 100% (diff: 100%)@@ master #4 diff @@
===================================
Files 4 4
Lines 44 44
Methods 0 0
Messages 0 0
Branches 0 0
===================================
Hits 44 44
Misses 0 0
Partials 0 0
|
|
合了, 你发吧 |
|
1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
Description of change