Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: avoid auto link detect error on IM #14

Merged
merged 1 commit into from
Feb 22, 2022
Merged

feat: avoid auto link detect error on IM #14

merged 1 commit into from
Feb 22, 2022

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 22, 2022

e.g.: DingTalk

@fengmk2 fengmk2 added the enhancement New feature or request label Feb 22, 2022
@fengmk2
Copy link
Member Author

fengmk2 commented Feb 22, 2022 •
edited
Loading

image

@codecov
Copy link

codecov bot commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #14 (2cd86eb) into master (79d8a1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines          427       432    +5     
  Branches        55        55           
=========================================
+ Hits           427       432    +5
Impacted Files Coverage Δ
lib/framework/formatter.ts 100.00% <100.00%> (ø)
lib/framework/framework_base_error.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f65bbf9...2cd86eb. Read the comment docs.

mansonchor
mansonchor approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@mansonchor mansonchor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhyyyq
zhyyyq approved these changes Feb 22, 2022
View reviewed changes
Copy link

@zhyyyq zhyyyq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mansonchor mansonchor merged commit 1992e0b into master Feb 22, 2022
@mansonchor mansonchor deleted the avoid-im-auto-link-detect branch February 22, 2022 03:17
@mansonchor
Copy link
Member

  • egg-errors@2.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atian25 atian25 atian25 approved these changes

@mansonchor mansonchor mansonchor approved these changes

@zhyyyq zhyyyq zhyyyq approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fengmk2 @mansonchor @atian25 @zhyyyq