-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default value for headers #4
Conversation
As `headers` 's default value is undefined , We cannot do the following ```js const error = new TooManyRequestsError(); error.headers['Retry-After'] = 120; ``` We have `Cannot set property 'Retry-After' of undefined` error
Please release a version after accepting this PR |
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
===========================================
- Coverage 99.7% 44.73% -54.97%
===========================================
Files 50 50
Lines 341 342 +1
Branches 47 47
===========================================
- Hits 340 153 -187
- Misses 0 189 +189
+ Partials 1 0 -1
Continue to review full report at Codecov.
|
Can you add a testcase? |
Added |
I don't see the testcase in your commit. |
@popomore Added , Check now |
CI is failed, so I commited by myself, Thanks for you PR. REF: #6 |
As
headers
's default value is undefined , We cannot do the followingWe have
Cannot set property 'Retry-After' of undefined
error