Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mem fs bugs in windows #48

Merged
merged 12 commits into from Feb 21, 2019
Merged

fix: mem fs bugs in windows #48

merged 12 commits into from Feb 21, 2019

Conversation

whxaxes
Copy link
Member

@whxaxes whxaxes commented Feb 21, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

修复 egg-init 在 windows 下由于 mem-fs 带来的卡死问题,发现引入 mem-fs 没多大意义,不如直接落盘,因此改成直接落盘。

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #48 into master will increase coverage by 0.2%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #48     +/-   ##
=========================================
+ Coverage   85.36%   85.57%   +0.2%     
=========================================
  Files           1        1             
  Lines         205      201      -4     
=========================================
- Hits          175      172      -3     
+ Misses         30       29      -1
Impacted Files Coverage Δ
lib/init_command.js 85.57% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0704648...000cdcf. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #48 into master will decrease coverage by 0.29%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #48     +/-   ##
=========================================
- Coverage   85.36%   85.07%   -0.3%     
=========================================
  Files           1        1             
  Lines         205      201      -4     
=========================================
- Hits          175      171      -4     
  Misses         30       30
Impacted Files Coverage Δ
lib/init_command.js 85.07% <100%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0704648...cb3a8a4. Read the comment docs.

@whxaxes whxaxes merged commit 318fc69 into master Feb 21, 2019
@whxaxes whxaxes deleted the fix-windows-mem-fs branch February 21, 2019 16:00
@whxaxes
Copy link
Member Author

whxaxes commented Feb 21, 2019

@atian25 我好像没有这个包的权限,你发一下?或者给我加一下权限

$ npm owner add wanghx egg-init

@whxaxes
Copy link
Member Author

whxaxes commented Feb 22, 2019

1.5.1

@rojer95
Copy link

rojer95 commented Mar 13, 2019

image

1.15.1版本依旧卡死额.

系统window10...

另外
egg-init --type sequelize schat-server 这样不会卡死
egg-init schat-server 这样会卡死

@whxaxes
Copy link
Member Author

whxaxes commented Mar 13, 2019

@rojer95 我晚上回去用 windows 试一下,现在身边没有 windows 机器

@bi-kai
Copy link

bi-kai commented Apr 30, 2019

@whxaxes
现在创建项目是用egg-init还是npm init egg --type=simple?
后者只是创建了一个普通package.json:
image

@atian25
Copy link
Member

atian25 commented Apr 30, 2019

升级你的 npm 版本,至少是 5.10+

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants