New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto remove expired files #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fengmk2, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jtyjty99999 to be a potential reviewer |
function* removeExpiredLogFiles(logdir, maxDays) { | ||
const files = yield fs.readdir(logdir); | ||
const expriedDate = moment().subtract(maxDays, 'days') | ||
.utcOffset(8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里我得改改。
fengmk2
force-pushed
the
remove-old-files
branch
from
July 25, 2016 17:23
05ecce3
to
3a34dbb
Compare
fengmk2
force-pushed
the
remove-old-files
branch
from
July 25, 2016 17:29
3a34dbb
to
07c4d35
Compare
fengmk2
force-pushed
the
remove-old-files
branch
from
July 25, 2016 17:32
07c4d35
to
893462a
Compare
合并后发 1.0.0 |
fengmk2
force-pushed
the
remove-old-files
branch
from
July 25, 2016 17:58
17cd8a2
to
e42c79f
Compare
fengmk2
force-pushed
the
remove-old-files
branch
from
July 25, 2016 18:07
e42c79f
to
d28138b
Compare
额,那不管它了 +1 |
嗯,合并吧。发布1.0.0 |
1.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm test
passesAffected core subsystem(s)
Description of change