Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto remove expired files #1

Merged
merged 3 commits into from Jul 26, 2016
Merged

feat: auto remove expired files #1

merged 3 commits into from Jul 26, 2016

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jul 25, 2016

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the annotation information on this pull request, we identified @jtyjty99999 to be a potential reviewer

function* removeExpiredLogFiles(logdir, maxDays) {
const files = yield fs.readdir(logdir);
const expriedDate = moment().subtract(maxDays, 'days')
.utcOffset(8)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里我得改改。

@fengmk2
Copy link
Member Author

fengmk2 commented Jul 25, 2016

合并后发 1.0.0

@fengmk2
Copy link
Member Author

fengmk2 commented Jul 25, 2016

windows 下跑 size ratote 很怪,文件明明存在,但是判断却是返回 false

image

@dead-horse
Copy link
Member

额,那不管它了 +1

@fengmk2
Copy link
Member Author

fengmk2 commented Jul 26, 2016

嗯,合并吧。发布1.0.0

@dead-horse dead-horse merged commit 81c7362 into master Jul 26, 2016
@dead-horse dead-horse deleted the remove-old-files branch July 26, 2016 02:11
@dead-horse
Copy link
Member

1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants